-
Notifications
You must be signed in to change notification settings - Fork 3k
Adjust STMF411xE IAR linker file to mbed-os memory needs. #7909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
define symbol __size_cstack__ = 0x4000; | ||
define symbol __size_heap__ = 0x8000; | ||
/*Heap 84kB and stack 8kB */ | ||
define symbol __size_cstack__ = 0x2000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's alignment for stack to be 1k @mprse please confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm, stack size should be 1k.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the stack size
Stack size decreased and heap size increased.
62fb351
to
86f966f
Compare
Stack size changed |
@KariHaapalehto Why is the PR change so specific? A single target against a single compiler? Also, is this required for 5.10? |
@cmonr This error only occur with IAR 7.x compiler, since it isn't supporting dynamic heap. This correction has been done already to stm32f439xx_flash.icf and it might be be good idea to check also other target in separate PR. Cloud client isn't working without this change, so it would be good to have in 5.10 |
This is covering same area as #7238, and is not inconsistent with it. That's covering multiple targets, but appears to be not fully complete, and doesn't currently touch this one. |
So @kjbracey-arm , |
If this is urgently needed for 5.10 because it's a key cloud client target, I'd say it can go now, and other platforms can get mopped up by #7238 during 5.11. (Although that is only covering stack sizes, not the additional heap size increase here.)
BTW @KariHaapalehto - are you suggesting IAR 8 does have dynamic heap? Would be good news if true. |
Looks like we should definitely get this one in for RC2 especially as #7238 will not come in until 5.11 by the looks of it. |
/morph build |
Build : SUCCESSBuild number : 3046 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2662 |
Test : FAILUREBuild number : 2819 |
Test CI needs to be restarted. Will restart aftetr 5.10-rc2 is generated. We had to cutoff RC2 to continue testing with new fixes. Still planning on getting this into 5.10. |
/morph test |
Test : SUCCESSBuild number : 2822 |
Would prefer for that heap size change to be tied to the application instead of making the change on the target itself, but I don't think we have that kind of mechanism to facilitate that. @mprse @kjbracey-arm @ARMmbed/team-st-mcd Final thoughts/OKs? |
Description
mbed cloud client needs more heap, so heap size increased.
8k is enough for stack, so stack size decreased.
New linker file configuration tested with HW, mbed cloud client is able to register to cloud
Pull request type