Skip to content

Adjust STMF411xE IAR linker file to mbed-os memory needs. #7909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

KariHaapalehto
Copy link
Contributor

Description

mbed cloud client needs more heap, so heap size increased.
8k is enough for stack, so stack size decreased.
New linker file configuration tested with HW, mbed cloud client is able to register to cloud

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 28, 2018 13:06
define symbol __size_cstack__ = 0x4000;
define symbol __size_heap__ = 0x8000;
/*Heap 84kB and stack 8kB */
define symbol __size_cstack__ = 0x2000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's alignment for stack to be 1k @mprse please confirm

Copy link
Contributor

@mprse mprse Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm, stack size should be 1k.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the stack size

Stack size decreased and heap size increased.
@KariHaapalehto
Copy link
Contributor Author

Stack size changed

@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

@KariHaapalehto Why is the PR change so specific? A single target against a single compiler?

Also, is this required for 5.10?

@KariHaapalehto
Copy link
Contributor Author

@cmonr This error only occur with IAR 7.x compiler, since it isn't supporting dynamic heap. This correction has been done already to stm32f439xx_flash.icf and it might be be good idea to check also other target in separate PR. Cloud client isn't working without this change, so it would be good to have in 5.10

@kjbracey
Copy link
Contributor

This is covering same area as #7238, and is not inconsistent with it. That's covering multiple targets, but appears to be not fully complete, and doesn't currently touch this one.

@jeromecoutant
Copy link
Collaborator

So @kjbracey-arm ,
you suggest to close this PR and make #7238 complete (all targets, all toolchain update)?

@kjbracey
Copy link
Contributor

If this is urgently needed for 5.10 because it's a key cloud client target, I'd say it can go now, and other platforms can get mopped up by #7238 during 5.11. (Although that is only covering stack sizes, not the additional heap size increase here.)

This error only occur with IAR 7.x compiler

BTW @KariHaapalehto - are you suggesting IAR 8 does have dynamic heap? Would be good news if true.

@adbridge
Copy link
Contributor

Looks like we should definitely get this one in for RC2 especially as #7238 will not come in until 5.11 by the looks of it.

@cmonr
Copy link
Contributor

cmonr commented Sep 10, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2018

Build : SUCCESS

Build number : 3046
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7909/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 11, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 11, 2018

Test CI needs to be restarted. Will restart aftetr 5.10-rc2 is generated.

We had to cutoff RC2 to continue testing with new fixes. Still planning on getting this into 5.10.

@cmonr
Copy link
Contributor

cmonr commented Sep 11, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 11, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

Would prefer for that heap size change to be tied to the application instead of making the change on the target itself, but I don't think we have that kind of mechanism to facilitate that.

@mprse @kjbracey-arm @ARMmbed/team-st-mcd Final thoughts/OKs?

@cmonr cmonr merged commit 8d9e2e5 into ARMmbed:master Sep 12, 2018
@KariHaapalehto KariHaapalehto deleted the f411re_iar branch September 19, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants