Skip to content

Resolve duplicate ADuCM3029 system return code #7920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Resolve duplicate ADuCM3029 system return code #7920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae492d9
Add consistent ADuCM3029 System return codes and remove duplicate codes
Aug 29, 2018
b57f902
Apply consistent system return code to adi_system_EnableRetention()
Aug 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...evices/TARGET_ADUCM302X/TARGET_ADUCM3029/TARGET_EV_COG_AD3029LZ/device/system_ADuCM3029.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,8 @@ void adi_system_EnableISRAM(bool bEnable)
* \n
* \n false :To disable retention during the hibernation.
* \n
* @return : SUCCESS : Configured successfully.
* FAILURE : For invalid bank.
* @return : ADI_SYS_SUCCESS : Configured successfully.
* ADI_SYS_FAILURE : For invalid bank.
* @note: Please note that respective linker file need to support the configuration. Only BANK-1 and
BANK-2 of SRAM is valid.
*/
Expand All @@ -269,7 +269,7 @@ uint32_t adi_system_EnableRetention(ADI_SRAM_BANK eBank,bool bEnable)
#ifdef ADI_DEBUG
if((eBank != ADI_SRAM_BANK_1) && (eBank != ADI_SRAM_BANK_2))
{
return FAILURE;
return ADI_SYS_FAILURE;
}
#endif
pADI_PMG0->PWRKEY = PWRKEY_VALUE_KEY;
Expand All @@ -282,5 +282,5 @@ uint32_t adi_system_EnableRetention(ADI_SRAM_BANK eBank,bool bEnable)
pADI_PMG0->SRAMRET &= ~((uint32_t)eBank >> 1);
}

return SUCCESS;
return ADI_SYS_SUCCESS;
}
9 changes: 6 additions & 3 deletions targets/TARGET_Analog_Devices/TARGET_ADUCM302X/TARGET_ADUCM3029/bsp/system_ADuCM3029.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,12 @@ extern "C" {
#endif /* __cplusplus */

/*! \cond PRIVATE */
#define SUCCESS 0u

#define FAILURE 1u
/*! System API function return codes */
typedef enum
{
ADI_SYS_SUCCESS = 0, /*!< No error detected. */
ADI_SYS_FAILURE, /*!< The API call failed. */
} ADI_SYS_RESULT;

/* System clock constant */
#define __HFOSC 26000000u
Expand Down