Add Support for Toshiba TMPM4G9 #7923

ghost · 2018-08-29T08:55:45Z

Description

Add mbed support for TOSHIBA's TMPM4G9 board.

Tested with all toolchains and test results are attached.
M4G9_GreenteaAutomated_TestResults.txt
M4G9_SingleAutomated_TestResults.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

ghost · 2018-08-31T11:54:38Z

Rebased

ghost · 2018-09-17T10:40:37Z

Hi @0xc0170, any status update on this PR.

0xc0170 · 2018-09-17T10:49:38Z

Hi @0xc0170, any status update on this PR.

I'll review it today

0xc0170 · 2018-09-18T10:07:00Z

targets/TARGET_TOSHIBA/TARGET_TMPM4G9/us_ticker.c

+    NVIC_ClearPendingIRQ(INTT32A00_A_CT_IRQn);
+}
+
+void us_ticker_free(void)


why this function is empty?

For successful compilation added this function body. However implemented the function now.

0xc0170 · 2018-09-18T10:25:11Z

targets/TARGET_TOSHIBA/TARGET_TMPM4G9/device/TOOLCHAIN_IAR/tmpm4g9f15.icf

+define symbol __ICFEDIT_region_BRAM_end__    = 0x200307FF;
+/*-Sizes-*/
+/*Heap 1/4 of ram and stack 1/8*/
+define symbol __ICFEDIT_size_cstack__   = 0xC000;


1k stack size

We have changed the stack size to 1K.

cmonr · 2018-09-23T14:23:54Z

/morph build

mbed-ci · 2018-09-23T19:03:51Z

Build : SUCCESS

Build number : 3141
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7923/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-09-24T02:05:21Z

Exporter Build : FAILURE

Build number : 2748
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7923/

0xc0170 · 2018-09-24T06:28:23Z

@ganesh-ramachandran Can you review the 2 failures ? What IAR version is required? This requires a new cmsis pack, will request the update (uvision failure)

mbed-ci · 2018-09-24T06:56:22Z

Test : SUCCESS

Build number : 2945
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7923/2945

ghost · 2018-09-24T10:19:10Z

Can you review the 2 failures ? What IAR version is required? This requires a new cmsis pack, will request the update (uvision failure)

@0xc0170, for IAR - issue is due to IAR version. Issue occurs in IAR V7.5... We are working with IAR 7.8... and no issues with that. For uvision failure - M4G9 keil pack to be installed (http://www.keil.com/dd2/toshiba/tmpm4g9f15fg/)

0xc0170 · 2018-09-24T11:03:23Z

The pack update was requested to be added (will be in couple of days). The IAR should be 7.8 for exporters, I noticed the build utility reportes 7.5.

@OPpuolitaival @studavekar What is the IAR version used by exporters?

0xc0170 · 2018-10-09T20:30:16Z

@ganesh-ramachandran Can you rebase? I would like to restart testing (we updated cmsis packs for uvision, need to check if this MCU is also in or will need to request one).

Sorry for the delay, there were various CI challenges in the last 2 weeks

ghost · 2018-10-10T04:43:28Z

@ganesh-ramachandran Can you rebase? I would like to restart testing (we updated cmsis packs for uvision, need to check if this MCU is also in or will need to request one).

Sorry for the delay, there were various CI challenges in the last 2 weeks

@0xc0170, Rebased. Thank you for the confirmation on cmsis packs for uvision. IAR exporter version is also fixed?

0xc0170 · 2018-10-10T20:13:55Z

/morph export-build

mbed-ci · 2018-10-10T21:55:16Z

Exporter Build : FAILURE

Build number : 2947
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7923/

cmonr · 2018-10-11T15:57:16Z

@ganesh-ramachandran Could you refer us to the IAR 7.x release notes where the device was added?

We were able to find this, but it's for 8.30: http://supp.iar.com/FilesPublic/UPDINFO/013240/arm/doc/infocenter/readme.ENU.html

ghost · 2018-10-12T06:41:45Z

@ganesh-ramachandran Could you refer us to the IAR 7.x release notes where the device was added?

We were able to find this, but it's for 8.30:

@cmonr Yes, TMPM4G9 is added in IAR 8.30, We have compiled and tested using mbed-cli with IAR 7.8. May be exporter build might succeed with IAR 7.8. Or when IAR 8.30 would be effective.

adbridge · 2018-10-12T10:13:13Z

/morph build

mbed-ci · 2018-10-12T11:06:15Z

Build : SUCCESS

Build number : 3336
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7923/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-12T12:13:39Z

Exporter Build : FAILURE

Build number : 2968
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7923/

mbed-ci · 2018-10-12T13:20:47Z

Test : SUCCESS

Build number : 3145
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7923/3145

0xc0170 · 2018-10-12T13:28:54Z

@cmonr Yes, TMPM4G9 is added in IAR 8.30, We have compiled and tested using mbed-cli with IAR 7.8. May be exporter build might succeed with IAR 7.8. Or when IAR 8.30 would be effective.

Based on this, exporters should be disabled for now (not supported in 7.x version), please remove iar definition.

We requested cmsis pack update in the CI to get exporters green

cmonr · 2018-10-12T13:49:27Z

Whoops. Jumped the gun again on restarting the export job.

Iar network license issue with mbed2 build
/morph mbed2-build

TMPM4G9 device was added in IAR 8.30. Based on this, exporters should be disabled for now (not supported in 7.x version).

ghost · 2018-10-15T05:04:06Z

Based on this, exporters should be disabled for now (not supported in 7.x version), please remove iar definition.

We requested cmsis pack update in the CI to get exporters green

@0xc0170 Removed IAR definition. Requesting to start CI tests again.

NirSonnenschein · 2018-10-15T05:12:47Z

/morph build

mbed-ci · 2018-10-15T05:56:44Z

Build : SUCCESS

Build number : 3355
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7923/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-15T07:04:38Z

Exporter Build : FAILURE

Build number : 2989
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7923/

mbed-ci · 2018-10-15T07:23:49Z

Test : SUCCESS

Build number : 3160
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7923/3160

NirSonnenschein · 2018-10-15T10:05:27Z

failures seem to be iar license related:
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-15T11:16:56Z

Exporter Build : FAILURE

Build number : 2990
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7923/

ghost · 2018-10-15T12:41:24Z

d like to restart testing (we updated cmsis packs for uvision, need to check if this MCU is also in or will need to request one).

cmsis pack for uvision to be updated to add this MCU (https://www.keil.com/dd2/toshiba/tmpm4g9f15fg/).
Requesting to update this pack to fix the uvision exporter build failure for TMPM4G9.

cmonr · 2018-10-15T19:59:12Z

@ganesh-ramachandran Correct. We still have an internal ticket open to add it into our expoter VM seeds.

cmonr · 2018-10-16T16:22:29Z

Should be ready now!

/morph export-build

mbed-ci · 2018-10-16T17:29:27Z

Exporter Build : SUCCESS

Build number : 3004
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7923/

0xc0170 added needs: review scope: new-target labels Aug 29, 2018

0xc0170 requested a review from ashok-rao August 29, 2018 10:20

0xc0170 requested changes Sep 18, 2018

View reviewed changes

0xc0170 approved these changes Sep 18, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Sep 20, 2018

0xc0170 added needs: work and removed needs: CI labels Sep 24, 2018

0xc0170 added the release-version: 5.10.2 label Oct 9, 2018

0xc0170 added needs: CI and removed needs: work labels Oct 10, 2018

cmonr added needs: work and removed needs: CI labels Oct 11, 2018

adbridge added needs: CI priority: high and removed needs: work labels Oct 12, 2018

Ganesh Ramachandran added 3 commits October 15, 2018 10:20

Added Support for TOSHIBA TMPM4G9

936ace0

Implemented us_ticker free() & modified IAR stack

0231c80

Removed IAR definition for TMPM4G9

fc92705

TMPM4G9 device was added in IAR 8.30. Based on this, exporters should be disabled for now (not supported in 7.x version).

cmonr merged commit af19a39 into ARMmbed:master Oct 16, 2018

cmonr removed the needs: CI label Oct 16, 2018

Add Support for Toshiba TMPM4G9 #7923

Add Support for Toshiba TMPM4G9 #7923

Uh oh!

Conversation

ghost commented Aug 29, 2018

Description

Pull request type

Uh oh!

ghost commented Aug 31, 2018

Uh oh!

ghost commented Sep 17, 2018

Uh oh!

0xc0170 commented Sep 17, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Sep 23, 2018

Uh oh!

mbed-ci commented Sep 23, 2018

Triggering tests

Uh oh!

mbed-ci commented Sep 24, 2018

Uh oh!

0xc0170 commented Sep 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbed-ci commented Sep 24, 2018

Uh oh!

ghost commented Sep 24, 2018

Uh oh!

0xc0170 commented Sep 24, 2018

Uh oh!

0xc0170 commented Oct 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 10, 2018

Uh oh!

0xc0170 commented Oct 10, 2018

Uh oh!

mbed-ci commented Oct 10, 2018

Uh oh!

cmonr commented Oct 11, 2018

Uh oh!

ghost commented Oct 12, 2018 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adbridge commented Oct 12, 2018

Uh oh!

mbed-ci commented Oct 12, 2018

Triggering tests

Uh oh!

mbed-ci commented Oct 12, 2018

Uh oh!

mbed-ci commented Oct 12, 2018

Uh oh!

0xc0170 commented Oct 12, 2018

Uh oh!

cmonr commented Oct 12, 2018

Uh oh!

ghost commented Oct 15, 2018

Uh oh!

NirSonnenschein commented Oct 15, 2018

Uh oh!

mbed-ci commented Oct 15, 2018

Triggering tests

Uh oh!

mbed-ci commented Oct 15, 2018

Uh oh!

mbed-ci commented Oct 15, 2018

Uh oh!

NirSonnenschein commented Oct 15, 2018

Uh oh!

mbed-ci commented Oct 15, 2018

Uh oh!

0xc0170 commented Sep 24, 2018 •

edited

Loading

0xc0170 commented Oct 9, 2018 •

edited

Loading

ghost commented Oct 12, 2018 •

edited by ghost

Loading