Skip to content

Qspi hal test refactoring/update #7925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 21, 2018
Merged

Qspi hal test refactoring/update #7925

merged 6 commits into from
Sep 21, 2018

Conversation

maciejbocianski
Copy link
Contributor

Description

  • code refactoring and preparation for enabling DPI/QPI tests
  • add DPI and QPI support
  • reduced multiple test count to 4
  • use common flash config header for all MX25RXX35F chips
  • fix sector erase max time on N25Q128A
  • randomize flash address during test to extend flash life (CI boards)

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@maciejbocianski
qspi_hal_test refactoring
db8cee0 
- code refactoring and preparation for enabling DPI/QPI tests
- reduced multiple test count to 4
- use common flash config header for all MX25RXX35F chips
- fix sector erase max time on N25Q128A
@maciejbocianski
Copy link
Contributor Author

@jamesbeyond @0xc0170 @SenRamakri @offirko
please review it

@maciejbocianski maciejbocianski force-pushed the qspi_hal_test_refactoring branch from 58cb363 to 4e5fd07 Compare August 29, 2018 14:51
@maciejbocianski maciejbocianski force-pushed the qspi_hal_test_refactoring branch from 4e5fd07 to b41ce6c Compare August 29, 2018 15:12
offirko
offirko approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@offirko offirko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@maciejbocianski
Copy link
Contributor Author

Tested on:

DISCO_F413ZH 
DISCO_L475VG_IOT01A
EFM32GG11_STK3701
NRF52840_DK

0xc0170
0xc0170 approved these changes Aug 30, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test utils look like they might become driver update or keep driver as it is ?

@maciejbocianski
Copy link
Contributor Author

maciejbocianski commented Aug 30, 2018 •
edited
Loading

Don't know why, but on nrf52840_dk only first 16 sectors of MX25R6435F are writable (checked: no protection was enabled).
Patch for test: use only first 16 blocks during test def7ee1

@0xc0170
There was a bug in qspi_command_transfer function, address was send LSB first but should be MSB first
Fix for this: 3a64383

@maciejbocianski
fix qspi address sending for nrf52
3a64383 
fix address sending in qspi_command_transfer
now address is send MSB first
@maciejbocianski maciejbocianski force-pushed the qspi_hal_test_refactoring branch from def7ee1 to 3a64383 Compare August 31, 2018 08:59
@maciejbocianski
qspi_hal_test - adjust used memory sector count
cffd581 
set flash sector count to 1024 for EFM32GG11_STK3701(MX25R3235F)
set flash sector count to 2048 for NRF52840_DK(MX25R6435F)
@maciejbocianski
Copy link
Contributor Author

maciejbocianski commented Aug 31, 2018 •
edited
Loading

@0xc0170 @jamesbeyond @offirko
please review again, two commits were added
3a64383
cffd581

jamesbeyond
jamesbeyond approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

offirko
offirko approved these changes Sep 1, 2018
View reviewed changes
Copy link
Contributor

@offirko offirko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for address MSB first looks good

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3092
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7925/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

Exporter Build : SUCCESS

Build number : 2701
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7925/

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

Test : FAILURE

Build number : 2881
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7925/2881

@maciejbocianski
Copy link
Contributor Author

tests-mbed_drivers-lp_ticker
NUCLEO_F746ZG - Toolchain: GCC_ARM

[1537279728.87][CONN][RXD] >>> Running case #11: 'Test multi ticker'... 
[1537279728.97][CONN][INF] found KV pair in stream: {{__testcase_start;Test multi ticker}}, queued... 
[1537279729.17][CONN][RXD] :83::FAIL: Expected 16 Was 32 
[1537279729.27][CONN][INF] found KV pair in stream: {{__testcase_finish;Test multi ticker;0;1}}, queued... 
[1537279729.37][CONN][RXD] >>> 'Test multi ticker': 0 passed, 1 failed with reason 'Assertion Failed'

I'm looking into it

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

@maciejbocianski Let us know if you find anything, we should restart CI here

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

Test : SUCCESS

Build number : 2910
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7925/2910

@0xc0170 0xc0170 merged commit 6a34251 into ARMmbed:master Sep 21, 2018
@maciejbocianski maciejbocianski mentioned this pull request Sep 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jamesbeyond jamesbeyond jamesbeyond approved these changes

@offirko offirko offirko approved these changes

@SenRamakri SenRamakri Awaiting requested review from SenRamakri

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maciejbocianski @0xc0170 @mbed-ci @jamesbeyond @offirko