Skip to content

corrected a typo in AT_CellularPower::opt_power_save_mode #7934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2018
Merged

corrected a typo in AT_CellularPower::opt_power_save_mode #7934

merged 1 commit into from
Sep 27, 2018

Conversation

wajahat-abbas
Copy link
Member

Description

The array should be at instead of pt

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team August 30, 2018 13:00
AriParkkila
AriParkkila approved these changes Aug 31, 2018
View reviewed changes
Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually 0 termination is redundant because strcpy adds that, but I think this is at least not harmful and a good precaution.

@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3174
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7934/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

Exporter Build : SUCCESS

Build number : 2772
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7934/

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

Test : SUCCESS

Build number : 2979
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7934/2979

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 27, 2018

/morph mbed2-build

@cmonr cmonr merged commit 9bd17d3 into ARMmbed:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wajahat-abbas @cmonr @mbed-ci @0xc0170 @AnttiKauppila @AriParkkila