-
Notifications
You must be signed in to change notification settings - Fork 3k
Export, MCUXpresso: Avoid assigning self.libraries #7937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I assume branch was created from dm subcommand one not master (extra commits here?) ? |
Just gonna wait until #7844 comes in, since that will collapse the PR changeset. |
Looking at the history, might need a rebase to clean it |
Rebasing. For some reason I did not get emails from this thread. |
ff243b6
to
121130e
Compare
@0xc0170 Rebase done. |
/morph build |
Build : SUCCESSBuild number : 3298 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2928 |
Test : SUCCESSBuild number : 3107 |
@cmonr passed CI, but only your review, does this require a tech-lead to move to "ready to merge"? |
@NirSonnenschein |
@cmonr , I get all of what you are saying and if you are ok with this then it is fine. |
Description
At some point in the past, self.libraries was changed from "assignable"
to not allowing assignment. This PR changes the MCUXpresso exporter to
avoid assigning this variable, and therefore fixes the exporter.
Pull request type