Skip to content

Export, MCUXpresso: Avoid assigning self.libraries #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

At some point in the past, self.libraries was changed from "assignable"
to not allowing assignment. This PR changes the MCUXpresso exporter to
avoid assigning this variable, and therefore fixes the exporter.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2018

I assume branch was created from dm subcommand one not master (extra commits here?) ?

@cmonr
Copy link
Contributor

cmonr commented Aug 30, 2018

Just gonna wait until #7844 comes in, since that will collapse the PR changeset.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

Just gonna wait until #7844 comes in, since that will collapse the PR changeset.

@cmonr Please review, 7844 was integrated

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2018

Looking at the history, might need a rebase to clean it

@theotherjimmy
Copy link
Contributor Author

Rebasing. For some reason I did not get emails from this thread.

@theotherjimmy theotherjimmy force-pushed the fix-mcuxpresso-lib-use branch from ff243b6 to 121130e Compare October 3, 2018 14:36
@theotherjimmy
Copy link
Contributor Author

@0xc0170 Rebase done.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2018

Build : SUCCESS

Build number : 3298
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7937/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

@NirSonnenschein
Copy link
Contributor

@cmonr passed CI, but only your review, does this require a tech-lead to move to "ready to merge"?

@cmonr
Copy link
Contributor

cmonr commented Oct 10, 2018

@NirSonnenschein
@theotherjimmy is effectively the tools tech lead. If we really want, we could ask @bridadan to also look, but when I'm not doing maintainer-y things, my time is spent working on tools :)

@NirSonnenschein
Copy link
Contributor

@cmonr , I get all of what you are saying and if you are ok with this then it is fine.

@cmonr cmonr merged commit 1eaa8a5 into ARMmbed:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants