Skip to content

Cellular Unittests refactored to GoogleTest framework #7944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2018

Conversation

AnttiKauppila
Copy link

@AnttiKauppila AnttiKauppila commented Aug 31, 2018

Cellular unittests ported to use GoogleTest framework

  • Also deleted old unittests from features/cellular

This can be targeted to 5.10.0-rc2.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@AnttiKauppila
Copy link
Author

@AriParkkila @mirelachirica @jarvte Please review

@AnttiKauppila AnttiKauppila changed the title Unittests Cellular Unittests refactored to GoogleTest framework Aug 31, 2018
@0xc0170 0xc0170 requested a review from a team August 31, 2018 12:03
@AnttiKauppila AnttiKauppila force-pushed the unittests branch 2 times, most recently from e27313b to ac75018 Compare September 9, 2018 10:22
@mbed-ci
Copy link

mbed-ci commented Sep 9, 2018

Build : SUCCESS

Build number : 3037
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7944/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 9, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 9, 2018

@AnttiKauppila
Copy link
Author

Multi ticker test timed out. Has nothing to do with these unit tests I am updating

@AnttiKauppila
Copy link
Author

@0xc0170 Can you retrigger only that one build (or merge this)

@AnttiKauppila
Copy link
Author

/morph build

@adbridge
Copy link
Contributor

@AnttiKauppila Please DO NOT trigger ci jobs yourself! Especially not during a release campaign. This looks like new functionality and we do not take new functionality into RC releases! @ChiefBureaucraticOfficer please comment

@cmonr
Copy link
Contributor

cmonr commented Sep 11, 2018

@AnttiKauppila PLease refrain from starting the builds. @0xc0170 is out this week. If you need to get a hold of the other maintainers, please use @ARMmbed/mbed-os-maintainers.

I've stopped the build since we're prioritizing the 5.10.0-rc2 build.

@cmonr
Copy link
Contributor

cmonr commented Sep 11, 2018

Marking for the first patch release for now, since RCs PRs should only be for fixing things found durring OOB.

@AnttiKauppila
Copy link
Author

Right. I would have liked this to land also in rc2, but I can wait for patch release as well.
This contains mostly only unit test related changes. (3 minor issues fixed which were found during testing).
Is it so that before rc2, nothing happens in CI? I have quite many PRs to be made and probably PRs start stacking also with other people. So it might be getting worse all the time

@cmonr
Copy link
Contributor

cmonr commented Sep 11, 2018

This contains mostly only unit test related changes. (3 minor issues fixed which were found during testing).

Good to know. If those three fixed issues were spun out into their own PR, I think we could take them for RC3. Otherwise, our policy is to take in test improvements and release them as often as possible.

Is it so that before rc2, nothing happens in CI? I have quite many PRs to be made and probably PRs start stacking also with other people. So it might be getting worse all the time

It's definitely more of a problem this release than most, since a couple of weeks ago we were averaging around 70-80 open PRs...
Every once in a while, if we need to push something through CI that is of dritical importance, we'll stop pending jobs and restart them when appropriate. It's not as bad as it sounds because at most, one PR is active in any given stage (Build/Export/Test) (actually, I think we run two Export PRs in parallel), and the rest are in a queue waiting to start.

Definitely hoping we can implement speed improvements without negatively affecting stability after the release.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2018

Still needs a rebase, there's a conflict

@AnttiKauppila
Copy link
Author

@0xc0170 Rebased

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3091
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7944/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

@cmonr cmonr merged commit f00c564 into ARMmbed:master Sep 18, 2018
@AnttiKauppila AnttiKauppila deleted the unittests branch September 19, 2018 09:17
@SierpG
Copy link

SierpG commented Sep 20, 2018

I got the latest version of the mbed master branch and I called in a MinGW environment in the UNITTESTS directory "python mbed_unittest.py".
However I got the following error: libat_cellular_device_unit.MbedOS.a(AT_CellularDevice.cpp.obj):AT_CellularDevice.cpp:(.text+0x18): undefined reference to `mbed::CellularDevice::CellularDevice()'

After changing the file
....\mbed-os-master\UNITTESTS\features\cellular\framework\AT\at_cellulardevice\unittest.cmake to

# Source files
set(unittest-sources
stubs/randLIB_stub.c
../features/cellular/framework/AT/AT_CellularDevice.cpp
../features/cellular/framework/device/CellularDevice.cpp # <==This line was missing
)

compiling and linking of the unit tests went ok.

@AnttiKauppila
Copy link
Author

Fix is already waiting to be merged:
#8176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants