-
Notifications
You must be signed in to change notification settings - Fork 3k
Cellular Unittests refactored to GoogleTest framework #7944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AriParkkila @mirelachirica @jarvte Please review |
e27313b
to
ac75018
Compare
Build : SUCCESSBuild number : 3037 Triggering tests/morph test |
Test : FAILUREBuild number : 2810 |
Exporter Build : SUCCESSBuild number : 2653 |
Multi ticker test timed out. Has nothing to do with these unit tests I am updating |
@0xc0170 Can you retrigger only that one build (or merge this) |
ac75018
to
99c83f5
Compare
/morph build |
@AnttiKauppila Please DO NOT trigger ci jobs yourself! Especially not during a release campaign. This looks like new functionality and we do not take new functionality into RC releases! @ChiefBureaucraticOfficer please comment |
@AnttiKauppila PLease refrain from starting the builds. @0xc0170 is out this week. If you need to get a hold of the other maintainers, please use @ARMmbed/mbed-os-maintainers. I've stopped the build since we're prioritizing the 5.10.0-rc2 build. |
Marking for the first patch release for now, since RCs PRs should only be for fixing things found durring OOB. |
Right. I would have liked this to land also in rc2, but I can wait for patch release as well. |
Good to know. If those three fixed issues were spun out into their own PR, I think we could take them for RC3. Otherwise, our policy is to take in test improvements and release them as often as possible.
It's definitely more of a problem this release than most, since a couple of weeks ago we were averaging around 70-80 open PRs... Definitely hoping we can implement speed improvements without negatively affecting stability after the release. |
99c83f5
to
abfbd9c
Compare
Still needs a rebase, there's a conflict |
abfbd9c
to
2b7a087
Compare
@0xc0170 Rebased |
/morph build |
Build : SUCCESSBuild number : 3091 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2700 |
Test : SUCCESSBuild number : 2880 |
I got the latest version of the mbed master branch and I called in a MinGW environment in the UNITTESTS directory "python mbed_unittest.py". After changing the file # Source files compiling and linking of the unit tests went ok. |
Fix is already waiting to be merged: |
Cellular unittests ported to use GoogleTest framework
This can be targeted to 5.10.0-rc2.
Pull request type