Skip to content

Add SPI_FREQ parameter to DATAFLASH block device configuration #7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2018
Merged

Add SPI_FREQ parameter to DATAFLASH block device configuration #7955

merged 1 commit into from
Sep 24, 2018

Conversation

yossi2le
Copy link
Contributor

@yossi2le yossi2le commented Sep 2, 2018

Description

This PR adds the SPI_FREQ configuration parameter to the DATAFLASH block device component.
This addon will allow the application to change the frequency of the SPI storage from the configuration side without committing any code changes.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Breaking change

@yossi2le yossi2le closed this Sep 2, 2018
@yossi2le yossi2le changed the title Adding the configuration parameter as default value in the constructor. Adding SPI_FREQ parameter to DATAFLASH block device configuration. Sep 2, 2018
@yossi2le yossi2le reopened this Sep 2, 2018
@NirSonnenschein NirSonnenschein requested a review from a team September 2, 2018 18:09
NirSonnenschein
NirSonnenschein approved these changes Sep 2, 2018
View reviewed changes
Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

offirko
offirko approved these changes Sep 3, 2018
View reviewed changes
Copy link
Contributor

@offirko offirko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@0xc0170 0xc0170 changed the title Adding SPI_FREQ parameter to DATAFLASH block device configuration. Add SPI_FREQ parameter to DATAFLASH block device configuration Sep 3, 2018
@cmonr
Copy link
Contributor

cmonr commented Sep 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2018

Build : SUCCESS

Build number : 3132
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7955/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2018

Exporter Build : SUCCESS

Build number : 2740
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7955/

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2018

Test : SUCCESS

Build number : 2934
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7955/2934

@cmonr cmonr merged commit 6fca23e into ARMmbed:master Sep 24, 2018
@adbridge adbridge mentioned this pull request Nov 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

@offirko offirko offirko approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yossi2le @cmonr @mbed-ci @0xc0170 @NirSonnenschein @offirko