Add nanostack mac tester and testcases #7996

JuhPuur · 2018-09-05T12:50:11Z

Description

Add the nanostack MAC tester to test applications and testcases.
Target 5.10-RC2 / 5.10.1

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Feature
[ ] Breaking change

mikter · 2018-09-05T13:00:13Z

@artokin @OPpuolitaival @kjbracey-arm can you check these changes

mikter

looks good for me

kjbracey · 2018-09-05T13:13:48Z

tools/test_configs/config_paths.json

@@ -13,5 +13,6 @@
    "6LOWPAN_ROUTER" : "6lowpanInterface_router.json",
    "THREAD_END_DEVICE" : "ThreadInterface_end_device.json",
    "THREAD_ROUTER" : "ThreadInterface_router.json",
-    "NO_NETWORK": "no_network.json"
+    "NO_NETWORK": "no_network.json",
+    "MAC_TESTER": "MACTester.json"


I would say "MAC tester" may be clear enough in context of Nanostack, but is too generic for Mbed OS as a whole - the name should say something about Nanostack or 802.15.4

I'm fine with changing it to something like NanostackMACTester.json

0xc0170 · 2018-09-17T08:37:56Z

/morph build

mbed-ci · 2018-09-17T09:20:48Z

Build : FAILURE

Build number : 3082
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7996/

0xc0170 · 2018-09-17T11:57:36Z

Please review the build failures (some are related to the changes)

JuhPuur · 2018-09-17T13:55:20Z

Rebased the branch. Weird stuff started happening when I tried to recreate that disappeared after rebasing.

cmonr · 2018-09-22T02:33:47Z

/morph build

mbed-ci · 2018-09-22T04:03:00Z

Build : FAILURE

Build number : 3124
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7996/

jupe · 2018-09-22T07:05:52Z

TEST_APPS/testcases/nanostack_mac_tester/ED_scan.py

+        del self.th
+        self.reset_dut()
+
+if __name__=='__main__':


i dont think user are able to run individual test anymore directly, maybe better to remove these blocks

JuhPuur · 2018-09-23T22:43:13Z

KW24D has this:
[Error] mbed_trace.h@435,45: 'dont_use_trace_helpers_outside_trace_calls' was not declared in this scope

KW41Z has this:
[DEBUG] Errors: /builds/ws/mbed-os-build-matrix/3124/KW41Z_GCC_ARM/sources/mbed-os/./TEST_APPS/device/nanostack_mac_tester/main.cpp:92: undefined reference to `NanostackRfPhy::get_default_instance()'

I don't understand why the first one appears, and the second one is weird since that change should be included already.

0xc0170 · 2018-09-24T05:20:31Z

/morph build

mbed-ci · 2018-09-24T06:10:32Z

Build : FAILURE

Build number : 3145
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7996/

0xc0170 · 2018-10-01T08:45:38Z

@JuhPuur Is this completed and ready for CI or still work ongoing (latest commit pushed minutes ago) ?

JuhPuur · 2018-10-01T09:00:26Z

Sorry about the delay. It's obvious that the application won't compile without its specific test config, so I set it to skip by default. Should have done that from the beginning. Should be done now.

0xc0170 · 2018-10-02T19:14:20Z

/morph build

mbed-ci · 2018-10-02T20:18:34Z

Build : FAILURE

Build number : 3217
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7996/

NirSonnenschein · 2018-10-03T09:40:37Z

looks like a build issue related tot he PR, please take a look.

JuhPuur · 2018-10-05T07:49:14Z

I don't think it's related to the PR. One failure for one target for one compiler, when the application added by the PR isn't compiled. The error logs have disappeared so i can't tell what was the actual cause.

0xc0170 · 2018-10-05T08:04:55Z

Looks like CI cleanup was not done properly, restarting

/morph build

mbed-ci · 2018-10-05T11:05:27Z

Build : SUCCESS

Build number : 3247
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7996/

Triggering tests

/morph test
/morph mbed2-build

0xc0170 · 2018-10-05T13:34:05Z

/morph export-build

mbed-ci · 2018-10-05T16:03:56Z

Exporter Build : SUCCESS

Build number : 2834
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7996/

mbed-ci · 2018-10-06T01:57:01Z

Test : SUCCESS

Build number : 3055
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7996/3055

kjbracey · 2018-10-09T11:36:27Z

This PR's use of thread flags just showed up while rebasing #7980 - didn't notice it at the time.

In case you ever touch this again, all the stuff about manual thread flags and rawserial and interrupt handlers and rx_buffer should no longer be needed - like some other test apps that have already been converted you can just use getchar as long as you configure platform.stdio-buffered-serial on.

Also makes the app nominally portable to a device using something other than serial console I/O.

kjbracey · 2018-10-09T11:39:29Z

Example of another app conversion: https://github.com/ARMmbed/mbed-client-testapp/pull/981/files

mikter reviewed Sep 5, 2018

View reviewed changes

kjbracey reviewed Sep 5, 2018

View reviewed changes

OPpuolitaival approved these changes Sep 5, 2018

View reviewed changes

cmonr added release-version: 5.11.0-rc1 needs: review release-version: 5.10.1 and removed release-version: 5.11.0-rc1 labels Sep 5, 2018

kjbracey approved these changes Sep 14, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Sep 17, 2018

0xc0170 added needs: work and removed needs: CI labels Sep 17, 2018

This was referenced Sep 17, 2018

Support for KW41Z ARMmbed/mbed-os-example-mesh-minimal#217

Closed

Add nanostack support for KW41Z #6622

Merged

JuhPuur mentioned this pull request Sep 18, 2018

Fixed test-config name ARMmbed/mbed-os-5-docs#742

Merged

cmonr added needs: CI and removed needs: work labels Sep 20, 2018

jupe reviewed Sep 22, 2018

View reviewed changes

cmonr added needs: work and removed needs: CI labels Sep 22, 2018

cmonr removed the release-version: 5.10.1 label Sep 27, 2018

0xc0170 added needs: CI and removed needs: work labels Oct 1, 2018

Juhani Puurula added 2 commits October 1, 2018 13:06

Skip the Nanostack MAC tester

e7e29da

Nanostack MAC tester: updated README.md

39328af

NirSonnenschein added needs: work and removed needs: CI labels Oct 3, 2018

0xc0170 added needs: CI and removed needs: work labels Oct 5, 2018

0xc0170 added the release-version: 5.10.2 label Oct 5, 2018

0xc0170 changed the title ~~Added nanostack mac tester and testcases~~ Add nanostack mac tester and testcases Oct 5, 2018

0xc0170 added ready for merge release-version: 5.10.1 and removed needs: CI release-version: 5.10.2 labels Oct 6, 2018

0xc0170 merged commit 5a8c63a into ARMmbed:master Oct 6, 2018

0xc0170 removed the ready for merge label Oct 6, 2018

Add nanostack mac tester and testcases #7996

Add nanostack mac tester and testcases #7996

Uh oh!

Conversation

JuhPuur commented Sep 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

mikter commented Sep 5, 2018

Uh oh!

mikter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Sep 17, 2018

Uh oh!

mbed-ci commented Sep 17, 2018

Uh oh!

0xc0170 commented Sep 17, 2018

Uh oh!

JuhPuur commented Sep 17, 2018

Uh oh!

cmonr commented Sep 22, 2018

Uh oh!

mbed-ci commented Sep 22, 2018

Uh oh!

jupe Sep 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JuhPuur commented Sep 23, 2018

Uh oh!

0xc0170 commented Sep 24, 2018

Uh oh!

mbed-ci commented Sep 24, 2018

Uh oh!

0xc0170 commented Oct 1, 2018

Uh oh!

JuhPuur commented Oct 1, 2018

Uh oh!

0xc0170 commented Oct 2, 2018

Uh oh!

mbed-ci commented Oct 2, 2018

Uh oh!

NirSonnenschein commented Oct 3, 2018

Uh oh!

JuhPuur commented Oct 5, 2018

Uh oh!

0xc0170 commented Oct 5, 2018

Uh oh!

mbed-ci commented Oct 5, 2018

Triggering tests

Uh oh!

0xc0170 commented Oct 5, 2018

Uh oh!

mbed-ci commented Oct 5, 2018

Uh oh!

mbed-ci commented Oct 6, 2018

Uh oh!

kjbracey commented Oct 9, 2018

Uh oh!

kjbracey commented Oct 9, 2018

Uh oh!

Uh oh!

JuhPuur commented Sep 5, 2018 •

edited

Loading

jupe Sep 22, 2018 •

edited

Loading