Add required header file and namespace element instead add all #8008

deepikabhavnani · 2018-09-05T16:57:07Z

Description

Source inside mbed-os should not be using "mbed.h" even in CPP files, instead required header file and namespace should be explicitly added inside mbed-os

With #7760 PR, we will give an option to remove namespace.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

cmonr · 2018-10-08T15:38:11Z

/morph build

mbed-ci · 2018-10-08T17:22:46Z

Build : FAILURE

Build number : 3281
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8008/

deepikabhavnani · 2018-10-08T17:58:42Z

@cmonr - Fixed the build issue.

cmonr · 2018-10-08T18:39:40Z

@deepikabhavnani Could you take a look at the Travis failures?

cmonr · 2018-10-11T15:41:42Z

/morph build

mbed-ci · 2018-10-11T17:44:27Z

Build : FAILURE

Build number : 3325
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8008/

0xc0170 · 2018-10-11T17:55:47Z

Please, review the build failures

cmonr · 2018-10-12T13:10:50Z

@deepikabhavnani This needs to wait until #7760 comes in, correct?

deepikabhavnani · 2018-10-12T14:26:05Z

This needs to wait until #7760 comes in, correct?

No the reverse, #7760 depends on this and few others. All the cleanup PR's have same purpose to remove "mbed.h" and "using namespace" from header files and are independent of each other.
Only 7760 depends on them, and it should be in minor release.

Query: Why is this marked for minor release and not patch. This PR is just cleanup and wont have any breaking changes.

cmonr · 2018-10-12T15:33:16Z

Anna did a scrub last night of PRs that are high priority to get in. The first pass was adding a release label so that they had our attention. the second pass evaluated if they can be brought into a patch.

Hence the questions earlier today :)

… all

1. RTOS is needed only for Stack stats Move+Add all required header files for RTOS into MBED_STACK_STATS_ENABLED define. Also added 'using namespace' 2. Add heap stats only when MBED_HEAP_STATS_ENABLED

deepikabhavnani · 2018-10-15T16:46:06Z

Rebased and resolved some of the test build issues

cmonr · 2018-10-15T16:48:36Z

Starting CI to test against large matrix of devices.

/morph build

mbed-ci · 2018-10-15T17:01:52Z

Build : FAILURE

Build number : 3356
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8008/

deepikabhavnani · 2018-10-15T18:16:59Z

Fixed last build issue, missed -DMBED_HEAP_STATS_ENABLED=1 -DMBED_STACK_STATS_ENABLED=1 -DMBED_TRAP_ERRORS_ENABLED=1 -DMBED_ALL_STATS_ENABLED in local build.

@cmonr - Can we try build once more to test against large matrix of devices

cmonr · 2018-10-15T20:03:42Z

@deepikabhavnani This one will take longer as other PRs are now in CI.

/morph build

mbed-ci · 2018-10-15T23:58:26Z

Build : FAILURE

Build number : 3363
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8008/

mbed.h was added in test, via greentea and utest header files. 'mbed.h' is removed from header files and required header file and namespace is added to CPP/C files

deepikabhavnani · 2018-10-16T16:51:52Z

Resolved few more, can we re-tigger build CI to make sure new changes are not breaking old ones

cmonr · 2018-10-16T16:53:29Z

/morph build

mbed-ci · 2018-10-16T18:05:08Z

Build : SUCCESS

Build number : 3373
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8008/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-16T19:56:45Z

Exporter Build : SUCCESS

Build number : 3008
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8008/

mbed-ci · 2018-10-17T00:44:15Z

Test : SUCCESS

Build number : 3178
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8008/3178

deepikabhavnani force-pushed the cleanup_features branch from f796e69 to af8995d Compare September 5, 2018 17:00

cmonr requested review from kjbracey and a team September 6, 2018 00:19

cmonr added the needs: review label Sep 6, 2018

kjbracey approved these changes Sep 14, 2018

View reviewed changes

OPpuolitaival approved these changes Sep 14, 2018

View reviewed changes

deepikabhavnani added needs: CI and removed needs: review labels Oct 5, 2018

cmonr added needs: work and removed needs: CI labels Oct 8, 2018

deepikabhavnani added needs: CI and removed needs: work labels Oct 10, 2018

0xc0170 added needs: work and removed needs: CI labels Oct 11, 2018

This was referenced Oct 11, 2018

Give an option to remove 'using namespace' #7760

Merged

Platform: fix missing namespace for SharedPtr #8329

Merged

adbridge added release-version: 5.11.0-rc1 priority: high labels Oct 12, 2018

cmonr added release-version: 5.10.2 and removed release-version: 5.11.0-rc1 labels Oct 12, 2018

Deepika added 4 commits October 15, 2018 10:57

Framework: Add required header file and namespace element instead add…

1fe6337

… all

Nanostack: Add required header file and namespace element instead add…

a47c6b8

… all

Netsocket: Add required header file and namespace element instead add…

f58e103

… all

Greentea: Add required header file and namespace element instead add all

e95d08e

1. RTOS is needed only for Stack stats Move+Add all required header files for RTOS into MBED_STACK_STATS_ENABLED define. Also added 'using namespace' 2. Add heap stats only when MBED_HEAP_STATS_ENABLED

deepikabhavnani force-pushed the cleanup_features branch 2 times, most recently from 2a3a9c8 to 935dfb9 Compare October 15, 2018 16:44

deepikabhavnani force-pushed the cleanup_features branch from 935dfb9 to 26bc5e0 Compare October 15, 2018 18:15

Resolve build issues in test

9db31d2

mbed.h was added in test, via greentea and utest header files. 'mbed.h' is removed from header files and required header file and namespace is added to CPP/C files

deepikabhavnani force-pushed the cleanup_features branch from 26bc5e0 to 9db31d2 Compare October 16, 2018 16:50

cmonr added needs: CI and removed needs: work labels Oct 16, 2018

cmonr merged commit d30ae07 into ARMmbed:master Oct 17, 2018

cmonr removed the needs: CI label Oct 17, 2018

Add required header file and namespace element instead add all #8008

Add required header file and namespace element instead add all #8008

Uh oh!

Conversation

deepikabhavnani commented Sep 5, 2018

Description

Pull request type

Uh oh!

cmonr commented Oct 8, 2018

Uh oh!

mbed-ci commented Oct 8, 2018

Build : FAILURE

Uh oh!

deepikabhavnani commented Oct 8, 2018

Uh oh!

cmonr commented Oct 8, 2018

Uh oh!

cmonr commented Oct 11, 2018

Uh oh!

mbed-ci commented Oct 11, 2018

Build : FAILURE

Uh oh!

0xc0170 commented Oct 11, 2018

Uh oh!

cmonr commented Oct 12, 2018

Uh oh!

deepikabhavnani commented Oct 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Oct 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepikabhavnani commented Oct 15, 2018

Uh oh!

cmonr commented Oct 15, 2018

Uh oh!

mbed-ci commented Oct 15, 2018

Build : FAILURE

Uh oh!

deepikabhavnani commented Oct 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Oct 15, 2018

Uh oh!

mbed-ci commented Oct 15, 2018

Build : FAILURE

Uh oh!

deepikabhavnani commented Oct 16, 2018

Uh oh!

cmonr commented Oct 16, 2018

Uh oh!

mbed-ci commented Oct 16, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Oct 16, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Oct 17, 2018

Test : SUCCESS

Uh oh!

Uh oh!

deepikabhavnani commented Oct 12, 2018 •

edited

Loading

cmonr commented Oct 12, 2018 •

edited

Loading

deepikabhavnani commented Oct 15, 2018 •

edited

Loading