Skip to content

Align to CMSIS defines for Non-Secure #8025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

deepikabhavnani
Copy link

Description

CMSIS updated the __DOMAIN_NS define to DOMAIN_NS. Update the define in existing code for non-secure part.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

CC @gaborkertesz @ccli8

Copy link
Contributor

@ccli8 ccli8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepikabhavnani That's OK.

@deepikabhavnani
Copy link
Author

deepikabhavnani commented Sep 7, 2018

M2351 is still in staging CI, wait for 5.10 release to test this PR.
@gaborkertesz - Can you verify locally if this fix works (https://github.com/ARMmbed/mbed-os/pull/8025/files#diff-9cf75aea879b6b9cc5026af0b8f708a3L429) for Musca as well?

@gaborkertesz
Copy link
Contributor

ARMC6 is working for Musca-A1 (after updating to this change in platform files). Please update GCC as well!

@kjbracey
Copy link
Contributor

Merge conflict - needs rebasing

CMSIS updated the __DOMAIN_NS define to DOMAIN_NS. Update the define
in existing code for non-secure part.
@deepikabhavnani
Copy link
Author

Rebased and updated for GCC as well.

@gaborkertesz
Copy link
Contributor

GCC update has been tested and works as expected for Musca-A1.

@deepikabhavnani
Copy link
Author

@ARMmbed/mbed-os-maintainers - Consider this as high priority for Musca.
@studavekar - Can we test this PR in staging as well for Nuvoton?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3099
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8025/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

@0xc0170 0xc0170 merged commit 81d0948 into ARMmbed:master Sep 19, 2018
@deepikabhavnani deepikabhavnani deleted the flag_update branch September 19, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants