Skip to content

Changed the reported SNR from unsigned to signed. #8034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

EnsilicaEdd
Copy link
Contributor

The rx metadata API returns the SNR of the received data. It's logically a signed value (since LoRa allows the signal to be below the noise floor, the SNR may be negative), and is signed within the stack.
But as it makes its way up the reporting chain, it becomes unsigned. I suspect this is not intentional, so I have simply changed the unsigned type to signed.

Aside: This is an unsolicited Pull Request without an associated Issue. I don't know whether this is acceptable etiquette, so please let me know if not.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Internally and logically it is a signed value.
@0xc0170 0xc0170 requested a review from a team September 7, 2018 10:27
Copy link
Contributor

@hasnainvirk hasnainvirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Looks good.

@hasnainvirk
Copy link
Contributor

@cmonr needs CI here. Minor change, should get in as fast as possible.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

@EnsilicaEdd Thanks for the fix. We will start CI once we complete 5.10.1 release (within a day).

@cmonr
Copy link
Contributor

cmonr commented Sep 20, 2018

Aside: This is an unsolicited Pull Request without an associated Issue. I don't know whether this is acceptable etiquette, so please let me know if not.

@EnsilicaEdd If there's a verified issue, PRs tend to get more attention, but submitting a PR without one is fine.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

Build : SUCCESS

Build number : 3148
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8034/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 24, 2018

/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

@0xc0170 0xc0170 merged commit a999289 into ARMmbed:master Sep 25, 2018
@EnsilicaEdd EnsilicaEdd deleted the snr_unsigned_signed branch September 27, 2018 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants