-
Notifications
You must be signed in to change notification settings - Fork 3k
Changed the reported SNR from unsigned to signed. #8034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Internally and logically it is a signed value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Looks good.
@cmonr needs CI here. Minor change, should get in as fast as possible. |
@EnsilicaEdd Thanks for the fix. We will start CI once we complete 5.10.1 release (within a day). |
@EnsilicaEdd If there's a verified issue, PRs tend to get more attention, but submitting a PR without one is fine. |
/morph build |
Build : SUCCESSBuild number : 3148 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2754 |
/morph mbed2-build |
Test : SUCCESSBuild number : 2952 |
The rx metadata API returns the SNR of the received data. It's logically a signed value (since LoRa allows the signal to be below the noise floor, the SNR may be negative), and is signed within the stack.
But as it makes its way up the reporting chain, it becomes unsigned. I suspect this is not intentional, so I have simply changed the unsigned type to signed.
Aside: This is an unsolicited Pull Request without an associated Issue. I don't know whether this is acceptable etiquette, so please let me know if not.
Pull request type