Skip to content

Move unittest paths to hyphens #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

bridadan
Copy link
Contributor

@bridadan bridadan commented Sep 10, 2018

Description

This PR is part of the 5.10 OOB process.

This PR proposes to move the naming convention for unittests to be consistent with the naming convention for greentea and icetea tests. Currently, unittests name test suites by separating directory names by underscores. So for example, a test contained in features/netsocket/NetworkInterface would be named features_netsocket_NetworkInterface. However, the existing test frameworks for greentea and icetea uses hyphens, so it would be named features-netsocket-NetworkInterface. This PR moves the naming to use hyphens to be inline with the current frameworks.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@SeppoTakalo
Copy link
Contributor

CC: @lorjala

@lorjala
Copy link
Contributor

lorjala commented Sep 12, 2018

Looks good.

@bridadan
Copy link
Contributor Author

Thanks for the review @SeppoTakalo and @lorjala. I did a best-effort search-and-replace for anything that was _ separated and moved them to - separated, hope I didn't miss anything 😄

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Build : SUCCESS

Build number : 3059
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8066/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 13, 2018

Test : SUCCESS

Build number : 2841
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8066/2841

@cmonr cmonr merged commit 2e5e23f into ARMmbed:master Sep 13, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants