-
Notifications
You must be signed in to change notification settings - Fork 3k
Spelling fixes and general readability improvements for TEST_APPS documentation #8067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Extend copy edits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bridadan 👍 Thanks for the great copy edits. I've added some more on top of yours.
Your edits look great, thanks @AnotherButler! |
You probably want to add the log folder to your .mbedignore file to prevent issues with build commands becoming too long over the time. | ||
You can also find the results from the tests in the `mbed-os/log` folder. | ||
|
||
You probably want to add the log folder to your `.mbedignore` file to prevent issues with build commands becoming too long over the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why build command touch even log files? Could it be ignored by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SeppoTakalo @OPpuolitaival Could y'all address this question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the concern is that mbed-os/log
adds another include directory to the already long list of include directories. As long as no subdirectories are added to mbed-os/log
, I think it'd be safe to remove this section in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we know that its always mbed-os/log
then I would be happy to add that into .mbedignore
file, just to be safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/morph build |
Build : SUCCESSBuild number : 3080 Triggering tests/morph test |
Test : SUCCESSBuild number : 2869 |
Exporter Build : SUCCESSBuild number : 2691 |
Description
This PR is part of the 5.10 OOB process.
I've included some spelling fixes and general readability improvements to the TEST_APPS documentation. None of the changes are particularly technical, I was just making tweaks as I read the document.
Pull request type