LoRaWAN: Refactoring compliance test code #8074
Conversation
|
@AnttiKauppila @kivaisan Please review. |
| tr_debug("TX: Channel=%d, DR=%d", _params.channel, next_channel.current_datarate); | ||
|
|
||
| uint8_t dr_offset = _lora_phy->apply_DR_offset(_params.sys_params.channel_data_rate, | ||
| uint8_t rx_dr = _lora_phy->apply_DR_offset(_params.sys_params.channel_data_rate, |
There was a problem hiding this comment.
Please rename to rx1_dr because this is RX1 specific.
| _params.sys_params.rx1_dr_offset); | ||
|
|
||
| _lora_phy->compute_rx_win_params(dr_offset, MBED_CONF_LORA_DOWNLINK_PREAMBLE_LENGTH, | ||
| tr_debug("TX: Channel=%d, TX DR=%d, RX DR=%d", |
There was a problem hiding this comment.
Maybe RX DR should be also changed as "RX1 DR"
features/lorawan/LoRaWANStack.cpp
Outdated
| #if defined(LORAWAN_COMPLIANCE_TEST) | ||
|
|
||
| lorawan_status_t LoRaWANStack::send_compliance_test_frame_to_mac() | ||
| lorawan_status_t LoRaWANStack::fetch_current_session_info(lorawan_session_t &session) |
There was a problem hiding this comment.
This probably should not be part of this PR?
hasnainvirk
force-pushed
the
compliance_testing
branch
from
883f856 to
0135ea0
Compare
While performing compliance tests with an industry tester, we realized that there was no need for any extra handling code for the compliance tests. The tests would run fine, if we only have a handling application. However, in normal operation we wouldn't like the network to send us any traffic on compliance testing port. To mitigate that, on the reception path we filter out any traffic on compliance testing port if compliance testing is not underway. User should define LORAWAN_COMPLIANCE_TEST macro in mbed_app.json to enable traffic on compliance test port.
hasnainvirk
force-pushed
the
compliance_testing
branch
from
0135ea0 to
e110856
Compare
|
@kivaisan Please review again especially the method is_port_valid(). |
|
@hasnainvirk Once we are into OOB for a minor release, only Critical or Blocking bugs found are generally considered for inclusion. There may be exceptions but that is the general policy. This however is a generic fix which is neither and thus can wait for 5.10.1. |
|
/morph build |
Build : SUCCESSBuild number : 3109 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2716 |
Test : FAILUREBuild number : 2899 |
|
/morph test |
|
@cmonr Failure not related to this PR. |
|
/morph test |
Test : SUCCESSBuild number : 2903 |
Description
While performing compliance tests with an industry tester, we realized
that there was no need for any extra handling code for the compliance
tests. The tests would run fine, if we only have a handling application.
However, in normal operation we wouldn't like the network to send us any
traffic on compliance testing port. To mitigate that, on the reception
path we filter out any traffic on compliance testing port if compliance
testing is not underway. User should define LORAWAN_COMPLIANCE_TEST macro
in mbed_app.json to enable traffic on compliance test port.
Pull request type
Target
5.10.1