-
Notifications
You must be signed in to change notification settings - Fork 3k
Lora: Fix sticky MAC command retransmissions #8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lora: Fix sticky MAC command retransmissions #8096
Conversation
@hasnainvirk @AnttiKauppila @kjbracey-arm please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Can you rebase? We will start CI |
This commit fixes the bug where sticky MAC commands were duplicated in send buffer everytime send() was called.
@0xc0170 Rebased. |
/morph build |
Build : SUCCESSBuild number : 3115 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2722 |
@kivaisan @hasnainvirk Are the functions in this file not meant to be used by application developers? |
Test : SUCCESSBuild number : 2908 |
@cmonr These are our stack internal methods, so supposed to be used by application directly. |
It's worth stating in the commit msg, to avoid later questioning the release version. |
Sorry, just noticed one critical typo in my earlier comment, so NOT supposed to be used by application directly. |
Description
This commit fixes the bug where sticky MAC commands were duplicated in
send buffer everytime send() was called.
Pull request type