Skip to content

Lora: Fix sticky MAC command retransmissions #8096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Lora: Fix sticky MAC command retransmissions #8096

merged 1 commit into from
Sep 21, 2018

Conversation

kivaisan
Copy link
Contributor

Description

This commit fixes the bug where sticky MAC commands were duplicated in
send buffer everytime send() was called.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

@hasnainvirk @AnttiKauppila @kjbracey-arm please review.

Copy link
Contributor

@hasnainvirk hasnainvirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

Can you rebase? We will start CI

This commit fixes the bug where sticky MAC commands were duplicated in
send buffer everytime send() was called.
@kivaisan
Copy link
Contributor Author

@0xc0170 Rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

Build : SUCCESS

Build number : 3115
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8096/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 20, 2018

@kivaisan @hasnainvirk Are the functions in this file not meant to be used by application developers?

19d90bd#diff-73c4e0f308c58824d9bfaeb1900924fc

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

@kivaisan
Copy link
Contributor Author

@cmonr These are our stack internal methods, so supposed to be used by application directly.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2018

@cmonr These are our stack internal methods, so supposed to be used by application directly.

It's worth stating in the commit msg, to avoid later questioning the release version.

@0xc0170 0xc0170 merged commit 0c8aa28 into ARMmbed:master Sep 21, 2018
@kivaisan
Copy link
Contributor Author

kivaisan commented Sep 21, 2018

Sorry, just noticed one critical typo in my earlier comment, so NOT supposed to be used by application directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants