Skip to content

STM32 L0 ADC internal channel fix #8103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Conversation

jeromecoutant
Copy link
Collaborator

Description

2 issues about ADC internal channels :

  • channel definition was wrong for STM32L072 targets in PinMap_ADC_Internal structure
  • Temperature sensor needs some longer stabilization time before reading the value

Manual internal tests have been performed in order to validate the correction.

Thx

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr requested a review from a team September 12, 2018 17:27
@@ -172,6 +172,12 @@ uint16_t adc_read(analogin_t *obj)

HAL_ADC_ConfigChannel(&obj->handle, &sConfig);

/* need to wait for some stabilization time after setting the TSEN bit in the ADC_CCR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wait is not needed on other STM32 series ?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 1, 2018

Build : SUCCESS

Build number : 3200
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8103/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

Test stage will be restarted after 5.10.1 RC + exporters

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 3, 2018

Build : SUCCESS

Build number : 3228
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8103/

Triggering tests

/morph test
/morph mbed2-build

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 4, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 4, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

@0xc0170 0xc0170 merged commit 0b1bc87 into ARMmbed:master Oct 5, 2018
@jeromecoutant jeromecoutant deleted the PR_L0_ADC branch October 8, 2018 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants