Skip to content

Unit tests: fix coverage exclude paths on Windows #8123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Unit tests: fix coverage exclude paths on Windows #8123

merged 1 commit into from
Sep 15, 2018

Conversation

lorjala
Copy link
Contributor

@lorjala lorjala commented Sep 13, 2018

Description

Govr requires forward slashed even on Windows for exclude/filter paths.

Fix for #8107.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@lorjala
Copy link
Contributor Author

lorjala commented Sep 13, 2018

@OPpuolitaival Review this.

@cmonr
Copy link
Contributor

cmonr commented Sep 14, 2018

Is this the only place where path slashes might be considered a problem? Does this handle relative paths as well?

@lorjala
Copy link
Contributor Author

lorjala commented Sep 14, 2018

@cmonr

Is this the only place where path slashes might be considered a problem?

Yes. Gcovr uses regular expressions as filters and their documentation suggest always using forward slashes.

Does this handle relative paths as well?

Yes.

@cmonr
Copy link
Contributor

cmonr commented Sep 14, 2018

/morph build

@cmonr cmonr added the risk: G label Sep 14, 2018
@mbed-ci
Copy link

mbed-ci commented Sep 14, 2018

Build : SUCCESS

Build number : 3072
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8123/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 14, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 15, 2018

@cmonr cmonr merged commit aee6325 into ARMmbed:master Sep 15, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 15, 2018
@lorjala lorjala deleted the fix_coverage_excludes branch November 19, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants