Skip to content

Fix authentication on a cellular network for Access Point Name (APN) #8147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 22, 2018
Merged

Fix authentication on a cellular network for Access Point Name (APN) #8147

merged 3 commits into from
Sep 22, 2018

Conversation

AriParkkila
Copy link

Description

Fix authentication on a cellular network for Access Point Name (APN).

Changes as per a commit:

  • APN authentication only on inactive context (Arm internal ref IOTCELL-1351)
  • Use proprietary commands for APN authentication on BG96
  • APN authentication currently not supported on HE910 and BC95

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@AriParkkila
Copy link
Author

@mirelachirica @jarvte @TeemuKultala please review

@AriParkkila AriParkkila changed the title Cell auth Fix authentication on a cellular network for Access Point Name (APN) Sep 17, 2018
jarvte
jarvte reviewed Sep 17, 2018
View reviewed changes
features/cellular/framework/AT/AT_CellularNetwork.cpp Outdated
@@ -197,6 +197,10 @@ void AT_CellularNetwork::urc_cgreg()
nsapi_error_t AT_CellularNetwork::set_credentials(const char *apn,
const char *username, const char *password)
{
if (!is_supported(AT_CGAUTH)) {
Copy link
Contributor

@jarvte jarvte Sep 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be check that if only apn is set then it does not matter if authentication is supported?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point due to APN can be given without username/password. See fixed.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

Build : SUCCESS

Build number : 3119
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8147/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

Exporter Build : SUCCESS

Build number : 2728
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8147/

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

Test : FAILURE

Build number : 2918
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8147/2918

@cmonr
Copy link
Contributor

cmonr commented Sep 21, 2018

I wish I could say that the PR needs work...

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 22, 2018

Test : FAILURE

Build number : 2923
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8147/2923

@cmonr
Copy link
Contributor

cmonr commented Sep 22, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 22, 2018

Test : SUCCESS

Build number : 2924
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8147/2924

@cmonr cmonr merged commit 73a96a6 into ARMmbed:master Sep 22, 2018
@cmonr cmonr removed the needs: CI label Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AriParkkila @0xc0170 @mbed-ci @cmonr @jarvte