Skip to content

Removed https from error url #8161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Sep 18, 2018

Description

Fixes issue where IAR will sometimes fail to build assembly files with error -11.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Github Pages will automatically redirect anyways
@cmonr
Copy link
Contributor Author

cmonr commented Sep 18, 2018

/morph mbed2-build

@kjbracey
Copy link
Contributor

Didn't #8017 fix this?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 18, 2018

Didn't #8017 fix this?

@TTornblom Can you please review?

@cmonr We need more details for this fix.

@TTornblom
Copy link
Contributor

Yes, #8017 should have fixed this.

@cmonr
Copy link
Contributor Author

cmonr commented Sep 18, 2018

Yes, #8017 should have fixed the issue, but a rebuild of #8023 after the merge did not change anything.

I didn't think that a rebase of #8023 was needed, but my understanding of the mbed2-build job might be incorrect.

@studavekar Does #8023 need a rebase to pull in #8017, which is now in master?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2018

@studavekar Does #8023 need a rebase to pull in #8017, which is now in master?

Already rebased. There will be something else going on. This one might be closed

@cmonr
Copy link
Contributor Author

cmonr commented Sep 20, 2018

Closing this since fixes are underway in #8023

@cmonr cmonr closed this Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants