Support Nuvoton's new target NUMAKER_IOT_M487 #8164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greentea/ARM |
Greentea/GCC_ARM |
Greentea/IAR |
CI/ARM |
0xc0170
approved these changes
Sep 18, 2018
|
@0xc0170 |
I can see 2 definitions in targets.json (no inheritance that 2 would benefit from) ? Would it make sense to create MCU M480 that would define what both can just inherit and add own definitions on top of it? |
|
Looks good. Just one - should it have prefix |
In targets.json, create MCU_M480 for inheritance by NUMAKER_PFM_M487/NUMAKER_IOT_M487.
ccli8
force-pushed
the
nuvoton_iot_m487
branch
from
6ffdff4 to
9d2fcdb
Compare
0xc0170
approved these changes
Sep 19, 2018
deepikabhavnani
approved these changes
Sep 20, 2018
|
/morph build |
Build : SUCCESSBuild number : 3121 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2730 |
Test : SUCCESSBuild number : 2921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Nuvoton's new target NUMAKER_IOT_M487, which is a branched version of existed NUMAKER_PFM_M487 with change on on-board modules.
Pull request type