Skip to content

Cellular: Quectel BG96 TCP socket support #8180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2018
Merged

Cellular: Quectel BG96 TCP socket support #8180

merged 1 commit into from
Oct 11, 2018

Conversation

kivaisan
Copy link
Contributor

Description

Add TCP Socket support for Quectel BG96.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

@AriParkkila @mirelachirica @AnttiKauppila please review.

@0xc0170 0xc0170 requested a review from a team September 19, 2018 11:22
AnttiKauppila
AnttiKauppila approved these changes Sep 19, 2018
View reviewed changes
Copy link

@AnttiKauppila AnttiKauppila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170 0xc0170 requested a review from a team September 24, 2018 12:52
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

Is this functionality change? Not just target implementation update ?

@kivaisan
Copy link
Contributor Author

kivaisan commented Oct 8, 2018

@0xc0170 This is a new feature.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 10, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

Build : SUCCESS

Build number : 3313
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8180/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

Exporter Build : SUCCESS

Build number : 2948
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8180/

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Test : SUCCESS

Build number : 3126
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8180/3126

@cmonr cmonr merged commit 3568c54 into ARMmbed:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kivaisan @0xc0170 @mbed-ci @AnttiKauppila @cmonr @NirSonnenschein