Skip to content

Unit tests: fix cellular athandler unit tests and wait() declaration conflict #8182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2018
Merged

Unit tests: fix cellular athandler unit tests and wait() declaration conflict #8182

merged 2 commits into from
Sep 22, 2018

Conversation

lorjala
Copy link
Contributor

@lorjala lorjala commented Sep 19, 2018

Description

Fix failing cellular unit tests on Windows and Mac OS.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team September 19, 2018 13:05
Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be prioritized as it is blocking unittesting in Mac OS X

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2018

/morph build

@SeppoTakalo
Copy link
Contributor

Btw, unittest building already working:
image

So why the need of morph build?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2018

So why the need of morph build?

Because the rest of the CI is required (the green policy). Now that we have unittests separate CI. We need to find a solution to this and document it. Once all its in place, we can update this.

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

Build : SUCCESS

Build number : 3122
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8182/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

@cmonr cmonr merged commit da0c5d9 into ARMmbed:master Sep 22, 2018
@cmonr cmonr removed the needs: CI label Sep 22, 2018
@lorjala lorjala deleted the fix_unittests branch November 19, 2018 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants