Skip to content

STM32: fix wrong LSE config in serial_baud function #8187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Sep 19, 2018

Description

The LSE configuration was incorrectly done in serial_baud function.

Fixes #8110

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team September 19, 2018 14:54
@adbridge
Copy link
Contributor

Might need to get this into 5.10.1 as it could be related to one of the client issues. (IOTHAL-356)

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

Is this fixes the error: Cannot initialize RTC with LSE ?

@cmonr
Copy link
Contributor

cmonr commented Sep 20, 2018

@adbridge It's unknown if it's able to correct the IOTHAL issue, since they're no longer able to reproduce the issue.

Will bring it in asap anyways, since RTC issues tend to be persistent across reflashes and can cause havoc on CI.

/morph build

FYI @ARMmbed/mbed-os-test

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

Build : SUCCESS

Build number : 3117
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8187/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 21, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 21, 2018

@0xc0170 0xc0170 merged commit 54afd1c into ARMmbed:master Sep 21, 2018
@bcostm bcostm deleted the fix_serial_lse branch September 21, 2018 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants