Skip to content

MIMXRT1050EVK: Add ENET support #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

mmahadevan108
Copy link
Contributor

Description

Add ENET support on the MXRT1050_EVK

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @cmonr @maclobdell

@mmahadevan108
Copy link
Contributor Author

This is dependent on PR #8175

@unsignedint
Copy link

How does the review process work?... I would be very keen to use this feature! It would be great to get it moving forward.

@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

@unsignedint You're helping right now!

Normally, we add people as reviewers to a PR who we know are familiar with the code and know how to guide a change in an intended direction. In this case, we haven't added anyone to review yet because it depends on another change that's in a different PR.

And we're doing what we can to bein back down the number of open PRs to a much more reasonable level.

@0xc0170 0xc0170 requested a review from a team October 1, 2018 11:12
@SeppoTakalo
Copy link
Contributor

This needs test report that shows results of EMAC and socket tests.

@mmahadevan108
Copy link
Contributor Author

Below are the ENET test results for IAR and ARM toolchains. I did come across an issue inside one of our SDK header files when testing on GCC_ARM, I am working with the internal team to get a fix. I will update this PR as soon as I hear back from them.
ENET_Test_IAR.txt
ENET_Test_ARM.txt

@SeppoTakalo
Copy link
Contributor

Thanks @mmahadevan108

Can you run extented set of Socket tests as instructed in https://github.com/ARMmbed/mbed-os/blob/master/TESTS/netsocket/README.md

If short: have "macros": ["MBED_EXTENDED_TESTS"] in your mbed_app.json or test configuration file.

Then I would like to see EMAC tests as well.
Please follow the Ethernet MAC porting guide and documentation how to run EMAC tests: https://github.com/ARMmbed/mbed-os/blob/master/TESTS/network/emac/README.md

@unsignedint
Copy link

Hey @mmahadevan108 did you get any update from your team? Myself and colleagues would really love this feature and, yes, we are using GCC_ARM.

@mmahadevan108
Copy link
Contributor Author

I should receive updated SDK file to address the GCC build issue around 10.25.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2018

This is dependent on PR #8175

No more depends on this PR. It is now waiting for the updated SDK files @mmahadevan108 - to fix the issue here ?

@@ -761,14 +761,18 @@
"supported_form_factors": ["ARDUINO"],
"core": "Cortex-M7FD",
"supported_toolchains": ["ARM", "GCC_ARM", "IAR"],
"extra_labels": ["NXP", "MCUXpresso_MCUS", "EVK", "MIMXRT1050", "IMX"],
"extra_labels": ["NXP", "MCUXpresso_MCUS", "EVK", "MIMXRT1050", "IMX", "NXP_EMAC"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NXP-specific EMAC?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the location for the NXP EMAC drivers

@mbeachmountain
Copy link

@mmahadevan108 Have you received the updated SDK file yet or have any updates on planned delivery?

@mmahadevan108
Copy link
Contributor Author

Still awaiting a fix, I have requested for an update.

@unsignedint
Copy link

Hey @mmahadevan108 did you get any updates yet?

@mmahadevan108
Copy link
Contributor Author

Nothing officially available yet, testing ongoing.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 6, 2018

Nothing officially available yet, testing ongoing.

Might be better if this is closed and reopened once the update and test is completed (if this is parked for more than few days, already been 2 weeks).

@unsignedint
Copy link

Before closing the issue it would be really nice to have an update from @mmahadevan108 with an estimated delivery date.

I am working on a new volume project using this part (RT1052), and we have the PCB layout already complete etc.. this Ethernet issue is really blocking us! It would be great if you could please expedite it internally or at least provide some realistic visibility for planning purposes. Thank you :)

@mmahadevan108
Copy link
Contributor Author

I have updated this PR to include fix for the build failure seen with GCC_ARM. I am working to add the test results for GCC_ARM and the additional tests requested.

@mmahadevan108
Copy link
Contributor Author

GCC_ARM test results below
ENET_Test_GCC_ARM.txt

@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

@mmahadevan108 One more rebase, and we should be able to start CI!

@mmahadevan108
Copy link
Contributor Author

Below are extended socket test results.
ENET_Extended_Test_IAR.txt
ENET_Extended_Test_ARM.txt
ENET_Extended_Test_GCC_ARM.txt

@cmonr cmonr added rollup PR and removed rollup PR labels Nov 13, 2018
@cmonr
Copy link
Contributor

cmonr commented Nov 13, 2018

In attempting to bundle this PR into the current rollup PR, this was not able to be automatically merged, and will require a rebase once the rollup PR, (primarily #8717) comes in.

Once #8717 is in, all future PRs will require considerably less rebasing due to how a majority of the merge conficts have occurred

Tl;dr: Once #8733 is in, this will need to be rebased.

Signed-off-by: Mahesh Mahadevan <[email protected]>
This fixes build failures seen with GCC_ARM

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

@cmonr I have rebased this PR.

@cmonr
Copy link
Contributor

cmonr commented Nov 14, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2018

Build : SUCCESS

Build number : 3625
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8190/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 14, 2018

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

That export failure does not look like it was due to the PR.

Will restart when able.

@mbed-ci
Copy link

mbed-ci commented Nov 15, 2018

@mmahadevan108
Copy link
Contributor Author

@cmonr I not clear why the test failures are occurring.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

@cmonr I not clear why the test failures are occurring.

Internal networking issue, I'll take this to a new rollup PR to test few PR at once

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

Note: This PR is now a part of a rollup PR (#8753).

In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr
Copy link
Contributor

cmonr commented Nov 15, 2018

Please ignore. I derped.

@cmonr cmonr merged commit d5cf53a into ARMmbed:master Nov 15, 2018
@mmahadevan108 mmahadevan108 deleted the feature-emac-mxrt1050 branch November 16, 2018 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants