-
Notifications
You must be signed in to change notification settings - Fork 3k
MIMXRT1050EVK: Add ENET support #8190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is dependent on PR #8175 |
How does the review process work?... I would be very keen to use this feature! It would be great to get it moving forward. |
@unsignedint You're helping right now! Normally, we add people as reviewers to a PR who we know are familiar with the code and know how to guide a change in an intended direction. In this case, we haven't added anyone to review yet because it depends on another change that's in a different PR. And we're doing what we can to bein back down the number of open PRs to a much more reasonable level. |
This needs test report that shows results of EMAC and socket tests. |
Below are the ENET test results for IAR and ARM toolchains. I did come across an issue inside one of our SDK header files when testing on GCC_ARM, I am working with the internal team to get a fix. I will update this PR as soon as I hear back from them. |
Thanks @mmahadevan108 Can you run extented set of Socket tests as instructed in https://github.com/ARMmbed/mbed-os/blob/master/TESTS/netsocket/README.md If short: have Then I would like to see |
Hey @mmahadevan108 did you get any update from your team? Myself and colleagues would really love this feature and, yes, we are using GCC_ARM. |
I should receive updated SDK file to address the GCC build issue around 10.25. |
No more depends on this PR. It is now waiting for the updated SDK files @mmahadevan108 - to fix the issue here ? |
@@ -761,14 +761,18 @@ | |||
"supported_form_factors": ["ARDUINO"], | |||
"core": "Cortex-M7FD", | |||
"supported_toolchains": ["ARM", "GCC_ARM", "IAR"], | |||
"extra_labels": ["NXP", "MCUXpresso_MCUS", "EVK", "MIMXRT1050", "IMX"], | |||
"extra_labels": ["NXP", "MCUXpresso_MCUS", "EVK", "MIMXRT1050", "IMX", "NXP_EMAC"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NXP-specific EMAC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the location for the NXP EMAC drivers
@mmahadevan108 Have you received the updated SDK file yet or have any updates on planned delivery? |
Still awaiting a fix, I have requested for an update. |
Hey @mmahadevan108 did you get any updates yet? |
Nothing officially available yet, testing ongoing. |
Might be better if this is closed and reopened once the update and test is completed (if this is parked for more than few days, already been 2 weeks). |
Before closing the issue it would be really nice to have an update from @mmahadevan108 with an estimated delivery date. I am working on a new volume project using this part (RT1052), and we have the PCB layout already complete etc.. this Ethernet issue is really blocking us! It would be great if you could please expedite it internally or at least provide some realistic visibility for planning purposes. Thank you :) |
I have updated this PR to include fix for the build failure seen with GCC_ARM. I am working to add the test results for GCC_ARM and the additional tests requested. |
GCC_ARM test results below |
@mmahadevan108 One more rebase, and we should be able to start CI! |
ba781be
to
3faaa32
Compare
Below are extended socket test results. |
In attempting to bundle this PR into the current rollup PR, this was not able to be automatically merged, and will require a rebase once the rollup PR, (primarily #8717) comes in. Once #8717 is in, all future PRs will require considerably less rebasing due to how a majority of the merge conficts have occurred Tl;dr: Once #8733 is in, this will need to be rebased. |
Signed-off-by: Mahesh Mahadevan <[email protected]>
This fixes build failures seen with GCC_ARM Signed-off-by: Mahesh Mahadevan <[email protected]>
3faaa32
to
d5cf53a
Compare
@cmonr I have rebased this PR. |
/morph build |
Build : SUCCESSBuild number : 3625 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3233 |
That export failure does not look like it was due to the PR. Will restart when able. |
Test : FAILUREBuild number : 3409 |
@cmonr I not clear why the test failures are occurring. |
Internal networking issue, I'll take this to a new rollup PR to test few PR at once |
Note: This PR is now a part of a rollup PR (#8753). In order to expedite remaining CI testing, this PR has been bundled into the above rollup PR. No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
Please ignore. I derped. |
Description
Add ENET support on the MXRT1050_EVK
Pull request type