-
Notifications
You must be signed in to change notification settings - Fork 3k
platform timer: Call timer start in enable #8210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -47,6 +47,7 @@ void platform_timer_enable(void) | |||
#endif | |||
// Prime the SingletonPtrs - can't construct from IRQ/critical section | |||
timer.get(); | |||
timer->start(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um. Seriously? I guess no-one was ever relying on this in the absence of frequency-hopping?
Yikes.
Anyway, if you're doing timer->start()
, don't need the "dummy" timer.get()
, so remove that line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and maybe put the "prime" comment above just the remaining timeout.get, as it's about that dummy get. timer->start() is inherently obvious.
But apparently not obvious enough for me to put in the code in the first place. Sigh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kjbracey-arm I guess, even without frequency hopping it caused some issues with MAC timer. Too short Ack wait durations caused MAC retransmissions etc. Please check the changes I made.
This timer was never started and therefore read_us returned always 0 causing bad timings.
@0xc0170 can you please initialise CI for this PR. Thanks, |
I can build it soon (there are two jobs in the queue now) but exporters are having an issue currently, we are investigating. |
/morph build |
Build : SUCCESSBuild number : 3280 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2905 |
Test : SUCCESSBuild number : 3088 |
This timer was never started and therefore read_us returned always 0 causing bad timings.
Description
This timer was never started and therefore read_us returned always 0 causing bad timings.
Tested with K64F and Nucleo-F429ZI
Pull request type