Skip to content

platform timer: Call timer start in enable #8210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

JarkkoPaso
Copy link

This timer was never started and therefore read_us returned always 0 causing bad timings.

Description

This timer was never started and therefore read_us returned always 0 causing bad timings.

Tested with K64F and Nucleo-F429ZI

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team September 21, 2018 07:31
@@ -47,6 +47,7 @@ void platform_timer_enable(void)
#endif
// Prime the SingletonPtrs - can't construct from IRQ/critical section
timer.get();
timer->start();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um. Seriously? I guess no-one was ever relying on this in the absence of frequency-hopping?

Yikes.

Anyway, if you're doing timer->start(), don't need the "dummy" timer.get(), so remove that line.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and maybe put the "prime" comment above just the remaining timeout.get, as it's about that dummy get. timer->start() is inherently obvious.

But apparently not obvious enough for me to put in the code in the first place. Sigh.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kjbracey-arm I guess, even without frequency hopping it caused some issues with MAC timer. Too short Ack wait durations caused MAC retransmissions etc. Please check the changes I made.

This timer was never started and therefore read_us returned always 0 causing bad timings.
@TuomoHautamaki
Copy link

@0xc0170 can you please initialise CI for this PR.

Thanks,
Tuomo

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

I can build it soon (there are two jobs in the queue now) but exporters are having an issue currently, we are investigating.

@cmonr
Copy link
Contributor

cmonr commented Oct 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

Build : SUCCESS

Build number : 3280
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8210/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants