Skip to content

Adjust stack & heap for IAR on STM32F412xG #8225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Adjust stack & heap for IAR on STM32F412xG #8225

merged 1 commit into from
Oct 9, 2018

Conversation

juhoeskeli
Copy link
Contributor

Description

Adjusted IAR Heap to 84kB and stack to 1kB

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change

@LMESTM
Copy link
Contributor

LMESTM commented Sep 24, 2018

@juhoeskeli Hi - could you provide more insights why you need such a size increase ?

@0xc0170 0xc0170 requested a review from a team September 24, 2018 08:38
@juhoeskeli
Copy link
Contributor Author

juhoeskeli commented Sep 24, 2018

@LMESTM Hello!
It seems with the latest cloud client RC with current mbed-os master we are consuming more heap than is available on targets with this MCU. It would be of course good to know why this is so, but I think it is a separate task.

For reference STM32F411xE has identical configuration that I am proposing in this PR.

@LMESTM
Copy link
Contributor

LMESTM commented Sep 24, 2018

@0xc0170 are their mbed-os requirements or guidelines on how to define stack and heap sizes ?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

@0xc0170 are their mbed-os requirements or guidelines on how to define stack and heap sizes ?

Stack alignment is ongoing effort (#7238). @bulislaw / @mprse what about the heap size?

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
From test result point of view, all was OK during night test with NUCLEO_F412ZG and IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 1, 2018

@0xc0170 are their mbed-os requirements or guidelines on how to define stack and heap sizes ?

Reference (the issue related to the stack and heap) : #4067.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference STM32F411xE has identical configuration that I am proposing in this PR.

As requested, there should be stack/heap definition for IAR. I referenced above the related issue. This PR is fine but not ideal solution to the problem.

@juhoeskeli
Copy link
Contributor Author

I agree it is not ideal, but can we go forward like this in the short time?

@juhoeskeli
Copy link
Contributor Author

To next patch release, please.

@cmonr
Copy link
Contributor

cmonr commented Oct 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

Build : SUCCESS

Build number : 3283
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8225/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants