Skip to content

test: fix RTC base time (#8214) #8230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2018
Merged

test: fix RTC base time (#8214) #8230

merged 1 commit into from
Oct 13, 2018

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Sep 24, 2018

Description

Change the base time value to more realistic:
START_TIME = 1537789823 # GMT: Monday, 24 September 2018 11:50:23

This fix has been proposed by STM in order to enhance test efficiency.
Current test version did not detect problem with RTC reset on STM F1 family boards, since the base time was too small.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Change the base time value to more realistic:
START_TIME = 1537789823 # GMT: Monday, 24 September 2018 11:50:23

This fix has been proposed by STM in order to enhance test efficiency.
Current test version did not detect problem with RTC reset on F1 family boards since the base time was too small.
@mprse mprse mentioned this pull request Sep 24, 2018
@0xc0170 0xc0170 requested review from c1728p9 and a team September 24, 2018 12:39
@bcostm
Copy link
Contributor

bcostm commented Sep 24, 2018

I ran the rtc tests on the NUCLEO_F103RB platform and now the rtc_reset test is well FAIL as planned :)

+-------------------+---------------+------------------------------+--------+--------------------+-------------+
| target            | platform_name | test suite                   | result | elapsed_time (sec) | copy_method |
+-------------------+---------------+------------------------------+--------+--------------------+-------------+
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_drivers-rtc       | OK     | 30.73              | default     |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_hal-rtc           | OK     | 50.62              | default     |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_hal-rtc_reset     | FAIL   | 21.15              | default     |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_hal-rtc_time      | OK     | 17.29              | default     |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_hal-rtc_time_conv | OK     | 38.0               | default     |
+-------------------+---------------+------------------------------+--------+--------------------+-------------+

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Build : SUCCESS

Build number : 3260
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8230/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

@NirSonnenschein
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

@mprse
Copy link
Contributor Author

mprse commented Oct 8, 2018

only tests-mbed_hal-flash test has failed on EV_COG_AD3029LZ / ARM. This looks not related.

@adbridge
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2018

@cmonr cmonr merged commit 8bf51be into ARMmbed:master Oct 13, 2018
@0xc0170 0xc0170 changed the title Fix for issue #8214 Fix RTC base time (#8214 Oct 24, 2018
@0xc0170 0xc0170 changed the title Fix RTC base time (#8214 test: fix RTC base time (#8214) Oct 24, 2018
@mbed-ci
Copy link

mbed-ci commented Oct 24, 2018

Exporter Build : FAILURE

Build number : 3071
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8230/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants