Skip to content

ST DISCO/NUCLEO: no default COMPONENT_SD #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jeromecoutant
Copy link
Collaborator

Description

There is no COMPONENT_SD on ST NUCLEO and DISCO boards.
So default pin configuration doesn't have any sense.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team September 24, 2018 13:37
@deepikabhavnani
Copy link

@jeromecoutant - Pin configs are not very well documented but the values in target overrides are not just for SD card on-board but also for Arduino header compatible pin outs.

@jeromecoutant
Copy link
Collaborator Author

@deepikabhavnani
after #7979 I will then need to add all NUCLEO and DISCO to add :

"target_overrides": {
    "NUCLEO_xxx": {
         "SPI_CS":   "SPI_CS"

:-(

@deepikabhavnani
Copy link

@jeromecoutant - Removing first will be a breaking change. Addition should be done before deletion. I am sorry for additional work in all targets, but that would be a cleaner solution :-)

@yossi2le
Copy link
Contributor

@deepikabhavnani
after #7979 I will then need to add all NUCLEO and DISCO to add :

"target_overrides": {
  "NUCLEO_xxx": {
       "SPI_CS":   "SPI_CS"

:-(

@jeromecoutant for now, you can leave the pins in target overrides of SD component as they are today. those has been taken from the sd-driver repository and hopefully should be correct. In the close future we will start a dialoge process with all teams and partener to decide on the exact SPI_ macros in PinNames.h file. I have a feeling after this procedure things may be much more clear.

@jeromecoutant jeromecoutant deleted the PR_SD_JSON branch September 25, 2018 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants