Tools: Don't traceback on missing linker script #8250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description The `mbed compile` would traceback when no linker script is found. This PR changes that behavior to make that into a NotSupportedException, which has decent user behavior. Fixes ARMmbed#7723 ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Breaking change
0xc0170
approved these changes
Sep 26, 2018
cmonr
approved these changes
Sep 26, 2018
yennster
reviewed
Oct 10, 2018
tools/build_api.py
Outdated
| @@ -532,6 +532,8 @@ def build_project(src_paths, build_path, target, toolchain_name, | |||
| # Change linker script if specified | |||
| if linker_script is not None: | |||
| resources.add_file_ref(linker_script, linker_script) | |||
| if not resources.get_file_refs(FileType.LD_SCRIPT): | |||
| raise NotSupportedException("No Linker Script found!") | |||
There was a problem hiding this comment.
I would change this exception to match the one in __init__.py: "No linker script found"
|
I'll remove the |
|
@yennster Done. Please re-review. |
|
/morph build |
Build : SUCCESSBuild number : 3412 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3039 |
Test : SUCCESSBuild number : 3209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
mbed compilewould traceback when no linker script is found.This PR changes that behavior to make that into a NotSupportedException,
which has decent user behavior.
Fixes #7723
Pull request type