Skip to content

Realtek-rtl8195am: Add MCU_ target #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

M-ichae-l
Copy link
Contributor

@M-ichae-l M-ichae-l commented Sep 27, 2018

Description

1, edit "targets.json" to let "REALTEK_RTL8195AM" target inherit from "MCU_RTL8195A"
2, change file structures for folder "Target_Realtek"
3, add "PeripheralPins.h" and "PeripheralPins.c"

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Breaking change

…hub.com/M-ichae-l/mbed-os into realtek-rtl8195am-Add-MCU_target-update

1, edit "targets.json" to let "REALTEK_RTL8195AM" target inherit from "MCU_RTL8195A"
2, change file structures for folder "Target_Realtek"
3, add "PeripheralPins.h" and "PeripheralPins.c"
@cmonr cmonr requested a review from a team September 27, 2018 15:37
@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

Making a note here for future @cmonr: This PR might cause headaches when release into a patch because of the file moves. No need to make changes to the PR, this is more to confirm if this is indeed happening.

@0xc0170 0xc0170 changed the title realtek-rtl8195am-Add-MCU_target-update Realtek-rtl8195am: Add MCU_ target Oct 1, 2018
@M-ichae-l
Copy link
Contributor Author

Looks like we can process to the CI check. This PR is blocking some new features implementation of RTL8195AM.

@M-ichae-l
Copy link
Contributor Author

I suggest applying the CI check. It has blocked some implementations for some time.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

I suggest applying the CI check. It has blocked some implementations for some time.

Sorry for the delays, as you might have noticed we've been having some challenges in CI and the number of needs CI. I'll schedule build now as the queue allows it.

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3248
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8266/

Triggering tests

/morph test
/morph mbed2-build

@studavekar
Copy link
Contributor

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@adbridge
Copy link
Contributor

adbridge commented Oct 8, 2018

@cmonr @0xc0170 This should not have gone in without the correction of the PR header...I have now fixed it.

@adbridge
Copy link
Contributor

adbridge commented Oct 8, 2018

Making a note here for future @cmonr: This PR might cause headaches when release into a patch because of the file moves. No need to make changes to the PR, this is more to confirm if this is indeed happening.

This has indeed caused issues that cannot easily be remedied!

error: patch failed: targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/TOOLCHAIN_ARM_STD/rtl8195a_rom.o:1
error: targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A/device/TOOLCHAIN_ARM_STD/rtl8195a_rom.o: patch does not apply
error: Did you hand edit your patch?

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

@cmonr
Copy link
Contributor

cmonr commented Oct 8, 2018

@ARMmbed/mbed-os-maintainers Thoughts on adding this (#8266 (comment)) nugget of information into docs somehow?

@0xc0170 0xc0170 mentioned this pull request Oct 9, 2018
@M-ichae-l M-ichae-l deleted the realtek-rtl8195am-Add-MCU_target-updates branch November 16, 2018 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants