Skip to content

Update mbed-coap to version 4.7.0 #8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

anttiylitokola
Copy link
Contributor

Description

  • Add function that can be used to clear the received blockwise payloads for example in the case of a connection error.
  • Silence compiler warning when CoAP duplicate detection is enabled.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

- Add function that can be used to clear the received blockwise payloads for example in the case of a connection error.
- Silence compiler warning when CoAP duplicate detection is enabled.
@anttiylitokola
Copy link
Contributor Author

@yogpan01, please review.

@yogpan01
Copy link
Contributor

Approved. This is needed for client to handle memory gracefully when it is recovering from connection break while in the middle of firmware download.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 2, 2018

Build : SUCCESS

Build number : 3215
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8273/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 2, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 4, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

@cmonr
Copy link
Contributor

cmonr commented Oct 8, 2018

@ChiefBureaucraticOfficer Could you take a look at this?

A new function was added, but it appears that this might be needed in a patch release for cloud client (correct @yogpan01?).

@ghost
Copy link

ghost commented Oct 8, 2018

@ChiefBureaucraticOfficer Could you take a look at this?

A new function was added, but it appears that this might be needed in a patch release for cloud client (correct @yogpan01?).

Please clarify - has the owner of COAP reviewed these changes? The changes are optional, no adoption is required by existing users? No other known behaviors are altered?

If the answers to all of the above are 'yes', then the process excursion is APPROVED for the PR.

@yogpan01
Copy link
Contributor

@0xc0170 @ChiefBureaucraticOfficer
CoAP changes are feature enhancement and are completely optional. Existing users of CoAP may or may not use it and it will not impact to any existing functionality of CoAP library.
Since, its a complete new API there is no changed behaviour in any of the existing source code or APIs.

@cmonr cmonr merged commit 2c296fc into ARMmbed:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants