*LPC546XX: Finish MCU Refactoring #8291

theotherjimmy · 2018-10-01T16:14:42Z

Description

The Mbed 2 release was broken for FF_LPC546XX as it would include
the entire mbed 2 build of the LPC546XX. This PR seperates these 2
builds completely by:

Removing non-shared extra labels from the MCU_LPC546XX target
Moving the target implementation to a shared target directory

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

0xc0170 · 2018-10-05T13:27:24Z

@mmahadevan108 Can you review?

0xc0170 · 2018-10-06T05:53:40Z

/morph build

mbed-ci · 2018-10-06T08:10:54Z

Build : FAILURE

Build number : 3259
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8291/

NirSonnenschein · 2018-10-06T08:38:23Z

Hi @theotherjimmy
there is a build failure and it looks related to the PR, please take a look:
[Error] mbed_boot_gcc_arm.c@35,47: 'INITIAL_SP' undeclared (first use in this function)
[DEBUG] Return: 1
[DEBUG] Output: ./rtos/TARGET_CORTEX/TOOLCHAIN_GCC_ARM/mbed_boot_gcc_arm.c: In function 'software_init_hook':
[DEBUG] Output: ./rtos/TARGET_CORTEX/TOOLCHAIN_GCC_ARM/mbed_boot_gcc_arm.c:35:47: error: 'INITIAL_SP' undeclared (first use in this function)
[DEBUG] Output: #define HEAP_SIZE ((uint32_t)((uint32_t)INITIAL_SP - (uint32_t)HEAP_START))
[DEBUG] Output: ^
[DEBUG] Output: ./rtos/TARGET_CORTEX/TOOLCHAIN_GCC_ARM/mbed_boot_gcc_arm.c:48:26: note: in expansion of macro 'HEAP_SIZE'
[DEBUG] Output: uint32_t free_size = HEAP_SIZE;
[DEBUG] Output: ^~~~~~~~~
[DEBUG] Output: ./rtos/TARGET_CORTEX/TOOLCHAIN_GCC_ARM/mbed_boot_gcc_arm.c:35:47: note: each undeclared identifier is reported only once for each function it appears in
[DEBUG] Output: #define HEAP_SIZE ((uint32_t)((uint32_t)INITIAL_SP - (uint32_t)HEAP_START))
[DEBUG] Output: ^
[DEBUG] Output: ./rtos/TARGET_CORTEX/TOOLCHAIN_GCC_ARM/mbed_boot_gcc_arm.c:48:26: note: in expansion of macro 'HEAP_SIZE'
[DEBUG] Output: uint32_t free_size = HEAP_SIZE;
[DEBUG] Output: ^~~~~~~~~
Failed to build library

cmonr · 2018-10-12T21:33:22Z

@theotherjimmy Rebased for you.

cmonr · 2018-10-17T14:32:13Z

/morph build

mbed-ci · 2018-10-17T16:02:33Z

Build : FAILURE

Build number : 3384
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8291/

0xc0170 · 2018-10-17T22:54:54Z

[Error] mbed_boot_arm_std.c@54,0: #20: identifier "INITIAL_SP" is undefined error in the build

theotherjimmy · 2018-10-19T15:32:27Z

@0xc0170 Sorry that took so long. The new commit should fix the problem.

cmonr · 2018-10-19T15:44:37Z

/morph build

mbed-ci · 2018-10-19T17:07:48Z

Build : FAILURE

Build number : 3407
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8291/

cmonr · 2018-10-19T19:15:00Z

Weeeeird.

All of the errors are the following:
Error: L6218E: Undefined symbol EMAC::get_default_instance()

mbed-ci · 2018-11-17T07:27:21Z

Build : SUCCESS

Build number : 3659
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8291/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-11-17T09:51:13Z

Exporter Build : SUCCESS

Build number : 3266
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8291/

0xc0170 · 2018-11-19T13:55:49Z

Unfortunately, this needs a rebase now. There was one addition to LPC family that was integrated and causing now conflicts 😢 I did not identify this conflict, would have waited with the addition.

### Description The Mbed 2 release was broken for FF_LPC546XX as it would include the entire mbed 2 build of the LPC546XX. This PR seperates these 2 builds completely by: * Removing non-shared extra labels from the MCU_LPC546XX target * Moving the target implementation to a shared target directory ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Breaking change

theotherjimmy · 2018-11-19T15:37:32Z

Rebased.

0xc0170 · 2018-11-19T15:49:16Z

Just the build (test might be aborted later to make this into the rollup)

/morph build

mbed-ci · 2018-11-19T16:51:30Z

Build : SUCCESS

Build number : 3675
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8291/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-11-19T19:07:09Z

Exporter Build : FAILURE

Build number : 3279
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8291/

0xc0170 · 2018-11-20T08:49:45Z

Exporter failure - EOFError. We will most likely add this to another rollup to complete testing

cmonr · 2018-11-22T02:45:09Z

CI job started.

mbed-ci · 2018-11-22T05:18:13Z

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 4
Build artifacts
Build logs

theotherjimmy mentioned this pull request Oct 1, 2018

Mbed 2 builds are broken (was: ff_lpc546xx: Library name 'platform' is not unique) #5887

Closed

0xc0170 requested a review from a team October 2, 2018 07:36

0xc0170 added the needs: review label Oct 2, 2018

0xc0170 requested a review from a team October 4, 2018 15:43

0xc0170 approved these changes Oct 5, 2018

View reviewed changes

0xc0170 requested a review from mmahadevan108 October 5, 2018 13:27

mmahadevan108 approved these changes Oct 5, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 5, 2018

NirSonnenschein added needs: work and removed needs: CI labels Oct 6, 2018

0xc0170 added the release-version: 5.10.2 label Oct 9, 2018

adbridge added the priority: high label Oct 12, 2018

cmonr force-pushed the fix-ff-lpc546xx branch from 352e353 to 7e2023d Compare October 12, 2018 21:32

cmonr added release-version: 5.10.3 and removed release-version: 5.10.2 labels Oct 18, 2018

0xc0170 added needs: CI and removed needs: work labels Oct 19, 2018

cmonr added the release-version: 5.11.0-rc1 label Nov 17, 2018

NirSonnenschein added the risk: G label Nov 18, 2018

0xc0170 added rollup PR needs: work and removed needs: CI labels Nov 19, 2018

0xc0170 removed the rollup PR label Nov 19, 2018

theotherjimmy added 3 commits November 19, 2018 09:37

Update mbed_rtx.h switch for new target naming

7520014

Move EMAC implementation to shared target

f41b78c

theotherjimmy force-pushed the fix-ff-lpc546xx branch from 64d895e to f41b78c Compare November 19, 2018 15:37

0xc0170 added needs: CI and removed needs: work labels Nov 19, 2018

NirSonnenschein added ready for merge needs: CI and removed needs: CI ready for merge labels Nov 22, 2018

0xc0170 merged commit 78bd531 into ARMmbed:master Nov 22, 2018

0xc0170 removed the ready for merge label Nov 22, 2018

*LPC546XX: Finish MCU Refactoring #8291

*LPC546XX: Finish MCU Refactoring #8291

Uh oh!

Conversation

theotherjimmy commented Oct 1, 2018

Description

Pull request type

Uh oh!

0xc0170 commented Oct 5, 2018

Uh oh!

0xc0170 commented Oct 6, 2018

Uh oh!

mbed-ci commented Oct 6, 2018

Uh oh!

NirSonnenschein commented Oct 6, 2018

Uh oh!

cmonr commented Oct 12, 2018

Uh oh!

cmonr commented Oct 17, 2018

Uh oh!

mbed-ci commented Oct 17, 2018

Uh oh!

0xc0170 commented Oct 17, 2018

Uh oh!

theotherjimmy commented Oct 19, 2018

Uh oh!

cmonr commented Oct 19, 2018

Uh oh!

mbed-ci commented Oct 19, 2018

Uh oh!

cmonr commented Oct 19, 2018

Uh oh!

mbed-ci commented Nov 17, 2018

Triggering tests

Uh oh!

mbed-ci commented Nov 17, 2018

Uh oh!

0xc0170 commented Nov 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Nov 19, 2018

Uh oh!

0xc0170 commented Nov 19, 2018

Uh oh!

mbed-ci commented Nov 19, 2018

Triggering tests

Uh oh!

mbed-ci commented Nov 19, 2018

Uh oh!

0xc0170 commented Nov 20, 2018

Uh oh!

cmonr commented Nov 22, 2018

Uh oh!

mbed-ci commented Nov 22, 2018

Uh oh!

Uh oh!

0xc0170 commented Nov 19, 2018 •

edited

Loading