Skip to content

Tools: Use logical paths in ignored_dirs #8303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 19, 2018
Merged

Tools: Use logical paths in ignored_dirs #8303

merged 4 commits into from
Oct 19, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

Exporting to GNU ARM Eclipse, E2 Studio, and other exclude-based IDEs
currently generats unusable project files online. This is because the
list of directories ignored in the scan is inconsistant about what sort
of paths are used: logical paths, or phisical paths. This patch makes
all paths in ignored_dirs logical. This should fix the excluding tags
in these project files.

Resolves #7155
Tested on partnerbeta.
Includes minor formatting fixes that I found at the time as seperate
commits.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@theotherjimmy
Tools: Use logical paths in ignored_dirs
f220628 
### Description

Exporting to GNU ARM Eclipse, E2 Studio, and other exclude-based IDEs
currently generats unusable project files online. This is because the
list of directories ignored in the scan is inconsistant about what sort
of paths are used: logical paths, or phisical paths. This patch makes
all paths in ignored_dirs logical. This should fix the excluding tags
in these project files.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change
@theotherjimmy
Fix minor formatting mistake
b84cef9
@theotherjimmy
Remove unused local
98e0faa
@theotherjimmy theotherjimmy mentioned this pull request Oct 2, 2018
Closed
@cmonr cmonr requested a review from TomoYamanaka October 8, 2018 18:35
@0xc0170 0xc0170 requested a review from a team October 9, 2018 15:52
TomoYamanaka
TomoYamanaka approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@TomoYamanaka TomoYamanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We will make a final confirmation when this PR merged on Arm Mbed Online environment because we don't know the verifying method at this time.

@cmonr cmonr mentioned this pull request Oct 10, 2018
Closed
@cmonr
Copy link
Contributor

cmonr commented Oct 10, 2018

This is such a strange flow.

This change doens't seem to be cooperating with a certain set of targets. Refer to these build logs: #8357 (comment)

@cmonr
Copy link
Contributor

cmonr commented Oct 17, 2018

/moprh build

@cmonr
Copy link
Contributor

cmonr commented Oct 18, 2018

/moprh build

@cmonr
Copy link
Contributor

cmonr commented Oct 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2018

Build : FAILURE

Build number : 3399
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8303/

@theotherjimmy
Copy link
Contributor Author

Should be fixed now @cmonr

@cmonr
Copy link
Contributor

cmonr commented Oct 19, 2018

Yay! Time to warm up the lab.
/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2018

Build : SUCCESS

Build number : 3406
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8303/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2018

Exporter Build : SUCCESS

Build number : 3036
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8303/

@mbed-ci
Copy link

mbed-ci commented Oct 19, 2018

Test : SUCCESS

Build number : 3206
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8303/3206

@cmonr cmonr merged commit c004aa8 into ARMmbed:master Oct 19, 2018
@cmonr cmonr removed the needs: CI label Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@TomoYamanaka TomoYamanaka TomoYamanaka approved these changes

Assignees
No one assigned
Labels
priority: high release-version: 5.10.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error occurs when building exported mbed-os programs on e2studio
6 participants
@theotherjimmy @cmonr @mbed-ci @0xc0170 @TomoYamanaka @adbridge