Skip to content

Guard Atmel RF driver build by DEVICE_I2C #8327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2018
Merged

Guard Atmel RF driver build by DEVICE_I2C #8327

merged 1 commit into from
Oct 9, 2018
+10 −2

Conversation

SeppoTakalo
Copy link
Contributor

Description

This module uses AT24MAC chip which is in I2C bus, so it requires
device to support I2C

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team October 4, 2018 13:08
kjbracey
kjbracey reviewed Oct 4, 2018
View reviewed changes
components/802.15.4_RF/atmel-rf-driver/source/at24mac.cpp Outdated
@@ -15,6 +15,9 @@
*/
#include "at24mac.h"

// This driver required I2C
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this comment is adding anything - if you want it, it's "requires".

@studavekar
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

Build : FAILURE

Build number : 3264
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8327/

@SeppoTakalo
Copy link
Contributor Author 

[DEBUG] Output: Unable to connect to the license server. Check that ARMLMD_LICENSE_FILE is set correctly, and the license server is available.
[DEBUG] Output: Information about this error is available at: http://ds.arm.com/support/lic56/m97
[DEBUG] Output:  General licensing information is available at: http://ds.arm.com/support/licensing/
[DEBUG] Output:  If you need further help, provide this complete error report to your supplier or [email protected].

Please restart the CI

Guard Atmel RF driver build by DEVICE_I2C
f16a99c 
This module uses AT24MAC chip which is in I2C bus, so it requires
device to support I2C
@SeppoTakalo
Copy link
Contributor Author

Extra comment removed as Kevin suggested.

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2018

Build : SUCCESS

Build number : 3294
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8327/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2018

Exporter Build : SUCCESS

Build number : 2918
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8327/

@NirSonnenschein
Copy link
Contributor

failure in mbed2-build is IAR license related - rerunning
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2018

Test : SUCCESS

Build number : 3100
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8327/3100

@0xc0170 0xc0170 merged commit 06dffda into ARMmbed:master Oct 9, 2018
@deepikabhavnani deepikabhavnani mentioned this pull request Oct 10, 2018
Closed
@deepikabhavnani deepikabhavnani mentioned this pull request Dec 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SeppoTakalo @studavekar @mbed-ci @NirSonnenschein @0xc0170 @kjbracey