Fix hard-fault when socket created using accept() is closed #8336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When socket created using accept() is closed by calling the close() method, "delete this" is executed which triggers the destructor call on TCPSocket which in turn calls close() once again. Because _stack is already 0 this results in a hard-fault. Add a check that skips the rest of the close() method is the _stack is already 0.
sentinelt
force-pushed
the
socket-closed
branch
from
2d55027 to
9b89ad2
Compare
SeppoTakalo
approved these changes
Oct 9, 2018
0xc0170
approved these changes
Oct 9, 2018
|
/morph export-build |
|
/morph build |
1 similar comment
|
/morph build |
Build : SUCCESSBuild number : 3333 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2965 |
Test : SUCCESSBuild number : 3141 |
|
/morph mbed2-build |
cmonr
approved these changes
Oct 12, 2018
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 2976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When socket created using accept() is closed by calling the close()
method, "delete this" is executed which triggers the destructor call
on TCPSocket which in turn calls close() once again. Because _stack
is already 0 this results in a hard-fault.
Add a check that skips the rest of the close() method if the _stack
is already 0.
Tested on NUCLEO-F767ZI. Applies both to master and to release-candidate branches.
Pull request type