Skip to content

A Reduced SPIF Block Device for Boot Loader #8349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2018
Merged

A Reduced SPIF Block Device for Boot Loader #8349

merged 2 commits into from
Oct 18, 2018

Conversation

offirko
Copy link
Contributor

@offirko offirko commented Oct 9, 2018

Description

Adding the original Reduced SPIF Block Device into mbed-os to be used only by the Boot Loader.
(The existing SPIF Block Device supports SFDP standard but is too large for the Boot Loader.)

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@offirko
Copy link
Contributor Author

offirko commented Oct 9, 2018

@bulislaw , @donatieng , @ARMmbed/mbed-os-maintainers , @dannybenor , @davidsaada .
I'd appreciate your review of a Reduced SPIF Block Device for Boot Loader use.

@0xc0170 0xc0170 requested review from a team October 9, 2018 14:09
0xc0170
0xc0170 previously requested changes Oct 16, 2018
View reviewed changes
components/storage/blockdevice/COMPONENT_RSPIF/mbed_lib.json Outdated
@@ -0,0 +1,109 @@
{
"name": "rspif-driver"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be formatted better? It's hard to read as it is

components/storage/blockdevice/COMPONENT_RSPIF/SPIFReducedBlockDevice.h Outdated
#define MBED_RSPIF_BLOCK_DEVICE_H

/*
#include <mbed.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this commented out? It would be better to remove it

@cmonr cmonr dismissed 0xc0170’s stale review October 16, 2018 15:11

Comments addressed. Please re-review.

@offirko
Copy link
Contributor Author

offirko commented Oct 17, 2018

@cmonr - unittest failed on non-related issue (lora), could you please trigger tests again?

@cmonr
Copy link
Contributor

cmonr commented Oct 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 17, 2018

Build : SUCCESS

Build number : 3390
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8349/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 17, 2018

Exporter Build : SUCCESS

Build number : 3021
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8349/

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2018

Test : SUCCESS

Build number : 3191
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8349/3191

@cmonr cmonr merged commit 515db95 into ARMmbed:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@dannybenor dannybenor dannybenor approved these changes

@davidsaada davidsaada davidsaada approved these changes

@donatieng donatieng Awaiting requested review from donatieng

@bulislaw bulislaw Awaiting requested review from bulislaw

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@offirko @cmonr @mbed-ci @0xc0170 @dannybenor @davidsaada