Skip to content

Renesas : Improve ARMCC linker script #8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

TomoYamanaka
Copy link
Contributor

@TomoYamanaka TomoYamanaka commented Oct 11, 2018

Description

To address issue #6975 , I remove inclusion processing and define the related macros at ARMCC linker script file.

For Arm toolchain build, Mbed 2(classic) programs occur an unexpected error if there is #include "mem_XXXX.h" in the script file. It seems that the linker script can't find the include file because mem_XXXX.h file is not in the same path with the linker script.

There is no problem with Mbed OS 5 programs.

@mbedNoobNinja
Could you review about changes to VK_RZ_A1H?

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

For Arm toolchain build, Mbed 2(classic) programs occur an unexpected error if there is "#include "mem_XXXX.h"" in the script file.
It seems that the linker script can't find the include file because "mem_XXXX.h" file is not in the same path with the linker script.
(Refer to Issue ARMmbed#6975.)
To address this issue, I remove inclusion processing and define the related macros at ARMCC linker script file.
@cmonr cmonr requested review from a team October 11, 2018 15:19
@cmonr
Copy link
Contributor

cmonr commented Oct 15, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2018

Build : SUCCESS

Build number : 3362
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8374/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2018

@cmonr cmonr merged commit deaa4fa into ARMmbed:master Oct 16, 2018
@TomoYamanaka TomoYamanaka deleted the improve_armcc_linkerscript branch October 17, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants