Fix for issue #8368

[mprse]

Description

This is fix for issue #8368.

Test is causing some problems on REALTEK_RTL8195AM and ARM compiler. There is some kind of memory issue. Probably there is not enough memory space for global data provided by the test. Data definitions have been moved into test function body so, they will land on stack. With this fix the test works on REALTEK_RTL8195AM/ARM.

Additionally optimize the test by using templates instead of global variables.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

[studavekar]

@mprse thanks for the fix 👍

[mprse]

@M-ichae-l
I made some further tests and found that on REALTEK_RTL8195AM and AMR compiler I can declare in the test up to 90 bytes of initialised global data (located in .data section). For example on GCC_ARM I am able to allocate 10k (couldn't check on IAR). Could you check that, maybe there is some problem is scatter file?

Here is the test code:

#include "utest/utest.h"
#include "unity/unity.h"
#include "greentea-client/test_env.h"

#include "mbed.h"
#include "mbed_mktime.h"

char buffer[1024*10] = {0xff};

using namespace utest::v1;

void test()
{
    memset(&buffer,0, sizeof(buffer));
}

Case cases[] = {
    Case("test", test)
};

utest::v1::status_t greentea_test_setup(const size_t number_of_cases)
{
    GREENTEA_SETUP(20, "default_auto");
    return greentea_test_setup_handler(number_of_cases);
}

Specification specification(greentea_test_setup, cases, greentea_test_teardown_handler);

int main()
{
    return Harness::run(specification);
}

[studavekar]

@ARMmbed/mbed-os-maintainers can you review?

[cmonr]

Why is this defined twice?

[mprse]

Sorry, but what is defined twice?

[cmonr]

Lines 54 and 93

[mprse]

Because these are two different template functions. Is it possible to define one template for many functions? I have never seen such case.

[cmonr]

It just seemed odd to me, but our local C++ expert (@geky) mentioend that it's par for the course. I'm use to seeing templates be used in classes, not functions.

[cmonr]

Iiinteresting. Have a question, but should be good.

[cmonr]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 3414
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8377/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 3040
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8377/

[mbed-ci]

Test : SUCCESS

Build number : 3210
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8377/3210