Skip to content

Fixed colorama Python package #8390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Oct 11, 2018

Description

Colorama package being at the top of the requirements.txt list causes other requirements to not be fufilled. All packages require <0.4.0, aka the latest 0.3.x patch release.

Since this was the first line in requirements.txt, colorama v0.4.0 was recently released: https://github.com/tartley/colorama/releases/tag/0.4.0

Once installed, manifest-tool and mbed-greentea would (properly) fail because they need a 0.3.x. Not sure why pip isn't able to correct this, but I digress.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Colorama package being at the top of the requirements.txt list causes other requirements to not be fufilled.
All packages require <0.4.0, aka the latest 0.3.x patch release.

:
@studavekar
Copy link
Contributor

These changes look good, we should also revisit other packages as well in requirement.txt like greentea which says mbed-greentea>=0.2.24 current version been 1.4.1

@cmonr
Copy link
Contributor Author

cmonr commented Oct 11, 2018

These changes look good, we should also revisit other packages as well in requirement.txt like greentea which says mbed-greentea>=0.2.24 current version been 1.4.1

Good point. Issue made for tracking: #8396

@cmonr
Copy link
Contributor Author

cmonr commented Oct 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2018

Build : SUCCESS

Build number : 3335
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8390/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 12, 2018

@adbridge adbridge merged commit 4c3b3f0 into ARMmbed:master Oct 12, 2018
@JanneKiiskila
Copy link
Contributor

Should there not be a follow-up task on the tools to be update to work with colorama 0.4.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants