Skip to content

At handler fixes #8401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2018
Merged

At handler fixes #8401

merged 4 commits into from
Oct 29, 2018

Conversation

mirelachirica
Copy link
Contributor

Description

  • ATHandler to reset match URC generated errors and continue response handling
  • ATHandler's mem_str fixed to work on matching strings
  • Added ATHandler option to write parameters without delimiters
  • AT handler to support only one callback per URC/prefix

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mirelachirica mirelachirica changed the title At handler changes 2 At handler fixes Oct 12, 2018
@0xc0170 0xc0170 requested a review from a team October 12, 2018 14:33
jarvte
jarvte approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@jarvte jarvte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also change set_urc_handler to void function as struct is created with new, no point checking if that was successful and otherwise it always returns ok. But only requested change is to fix doxygen.

features/cellular/framework/AT/ATHandler.h Outdated
@@ -277,6 +276,12 @@ class ATHandler {
*/
void set_default_delimiter();

/** Defines behaviour for using or ignoring the delimiter within an AT command
*
* @param flag indicating if delimiter should be used or not
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flag ->use_delimeter

@cmonr
Copy link
Contributor

cmonr commented Oct 19, 2018

@jarvte Could you take another look? Loos kike updates to this PR were made.

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 22, 2018

Build : FAILURE

Build number : 3427
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8401/

@cmonr
Copy link
Contributor

cmonr commented Oct 22, 2018

Please take a look at the build failures.

@mirelachirica
Copy link
Contributor Author

Now rebased and fixed the build errors.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

Build : SUCCESS

Build number : 3494
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8401/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

Exporter Build : SUCCESS

Build number : 3111
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8401/

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

Test : SUCCESS

Build number : 3278
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8401/3278

@cmonr cmonr merged commit 13d6703 into ARMmbed:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@jarvte jarvte jarvte approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mirelachirica @cmonr @NirSonnenschein @mbed-ci @0xc0170 @jarvte @adbridge