-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Ice Tea SPI communication test. #8443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ice Tea SPI communication test. #8443
Conversation
@ARMmbed/mbed-os-hal When y'all have a chance. |
cfe23f6
to
1497231
Compare
1497231
to
7326cfb
Compare
7326cfb
to
41965bc
Compare
Looks like its ready. Please review. Last results can be found below: Note that reference SPI implementation for K66F does not support lsb ordering, half duplex mode, and slave has some limitations regarding clock polarity and phase. These test cases are failing. More details about the test can be found here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/morph build |
Build : FAILUREBuild number : 3567 |
@ARMmbed/mbed-os-maintainers could you put do_not_merge tag on this PR for now, |
I chcecked the build failures. Symbols from the configuration are undefined, new hal api definition is missing and array sizes are not constant. Can we use only arrays with constant sizes? |
689890e
to
85413ff
Compare
41965bc
to
1961766
Compare
Modified Half-Duplex testing and added definition of port which is used for half-duplex mode to the |
@mprse Looks like this one is ready for CI? |
@donatieng @ithinuel @jamesbeyond All good? Looks like CI is ready to be started. |
@mprse When you get a chance, please rebase your PR. I updated the base branch with fixes for Travis CI. |
This PR requres PR #8445 |
@MarceloSalazar @screamerbg Could y'all look this over sometime soon? @mprse This needs a rebase. |
@mprse Rebase when available. |
cd9eb90
to
52ffce7
Compare
Rebased after reference impl has been merged into the feature branch. |
f3429a3
to
9b1ccaa
Compare
@mprse Please rebase again (sorry). The base branch has been rebased and updated. |
52ffce7
to
269d150
Compare
Rebased after spi feature branch has been rebased on master to solve Travis issue. |
9b1ccaa
to
c81f1e5
Compare
269d150
to
e73b496
Compare
e73b496
to
4984485
Compare
Rebased and fixed style. |
Description
Provide SPI communication test which uses IceTea Framework.
This PR can not be merged until PR which defines the new HAL API and adds at least one example implementation is merged. Probably then the test will have to be adapted to the final API version.
Detailed description can be found in README.md file in the test case folder.
List of PRs with related tests
Please assign @ithinuel as a reviewer.
Pull request type