Skip to content

Add Ice Tea SPI communication test. #8443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Oct 16, 2018

Description

Provide SPI communication test which uses IceTea Framework.

This PR can not be merged until PR which defines the new HAL API and adds at least one example implementation is merged. Probably then the test will have to be adapted to the final API version.

Detailed description can be found in README.md file in the test case folder.

List of PRs with related tests

PR Description
RFC SPI: Reference Implementation. #8445 New HAL API definition and example implementations for K66F anf NUCLEO_F429ZI
Add SPI test and test header file. #7976 SPI Green Tea basic test
Add GreeTea SPI communication test. #8216 Two boards Green Tea SPI communication test (closed)
Add Ice Tea SPI communication test. #8443 Two boards Ice Tea SPI communication test
Add one board Green Tea SPI Communication Test #8919 One board Green Tea SPI communication test

Please assign @ithinuel as a reviewer.

Pull request type

[] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

@cmonr
Copy link
Contributor

cmonr commented Oct 25, 2018

@ARMmbed/mbed-os-hal When y'all have a chance.

@mprse mprse changed the title Add Ice Tea SPI communication test. Add Ice Tea SPI communication test - wip. Oct 26, 2018
@mprse mprse force-pushed the spi_feature_branch_test_com_icetea branch from cfe23f6 to 1497231 Compare October 26, 2018 09:43
@mprse
Copy link
Contributor Author

mprse commented Oct 26, 2018

I pushed an update of the test and documentation.
Example test output on K66F can be found below:
example

Note that we are still solving test/driver issues.

@mprse mprse force-pushed the spi_feature_branch_test_com_icetea branch from 1497231 to 7326cfb Compare October 29, 2018 13:11
@mprse mprse changed the title Add Ice Tea SPI communication test - wip. Add Ice Tea SPI communication test. Oct 29, 2018
@mprse mprse force-pushed the spi_feature_branch_test_com_icetea branch from 7326cfb to 41965bc Compare October 30, 2018 12:44
@mprse
Copy link
Contributor Author

mprse commented Oct 30, 2018

Looks like its ready. Please review.

Last results can be found below:
image

Note that reference SPI implementation for K66F does not support lsb ordering, half duplex mode, and slave has some limitations regarding clock polarity and phase. These test cases are failing.

More details about the test can be found here:
https://github.com/mprse/mbed-os/tree/spi_feature_branch_test_com_icetea/TEST_APPS/testcases/test_spi_com

Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mprse! I'll let @ithinuel confirm that he's happy with this.

@donatieng donatieng requested a review from ithinuel October 31, 2018 14:55
@cmonr
Copy link
Contributor

cmonr commented Nov 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 7, 2018

Build : FAILURE

Build number : 3567
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8443/

@jamesbeyond
Copy link
Contributor

@ARMmbed/mbed-os-maintainers could you put do_not_merge tag on this PR for now,
We need to consolidate this PR with Partner Enablement Team before it can be merged.
nevertheless, we do want CI run on this one to identify any potential issues.

@mprse
Copy link
Contributor Author

mprse commented Nov 7, 2018

I chcecked the build failures. Symbols from the configuration are undefined, new hal api definition is missing and array sizes are not constant. Can we use only arrays with constant sizes?

@0xc0170 0xc0170 force-pushed the feature-hal-spec-spi branch from 689890e to 85413ff Compare November 12, 2018 17:38
@mprse mprse force-pushed the spi_feature_branch_test_com_icetea branch from 41965bc to 1961766 Compare November 13, 2018 15:37
@mprse
Copy link
Contributor Author

mprse commented Nov 13, 2018

Modified Half-Duplex testing and added definition of port which is used for half-duplex mode to the mbed_app.json

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2018

@mprse Looks like this one is ready for CI?

@cmonr
Copy link
Contributor

cmonr commented Dec 5, 2018

@donatieng @ithinuel @jamesbeyond All good? Looks like CI is ready to be started.

@cmonr
Copy link
Contributor

cmonr commented Dec 5, 2018

@mprse When you get a chance, please rebase your PR.

I updated the base branch with fixes for Travis CI.

@mprse
Copy link
Contributor Author

mprse commented Dec 5, 2018

This PR requres PR #8445

@cmonr
Copy link
Contributor

cmonr commented Dec 19, 2018

@MarceloSalazar @screamerbg Could y'all look this over sometime soon?

@mprse This needs a rebase.

@cmonr
Copy link
Contributor

cmonr commented Jan 4, 2019

@mprse Rebase when available.

@mprse mprse force-pushed the spi_feature_branch_test_com_icetea branch from cd9eb90 to 52ffce7 Compare January 9, 2019 09:10
@mprse
Copy link
Contributor Author

mprse commented Jan 9, 2019

Rebased after reference impl has been merged into the feature branch.
This one is ready for review and CI.

@0xc0170 0xc0170 force-pushed the feature-hal-spec-spi branch from f3429a3 to 9b1ccaa Compare January 9, 2019 16:16
@cmonr
Copy link
Contributor

cmonr commented Jan 9, 2019

@mprse Please rebase again (sorry). The base branch has been rebased and updated.

@mprse
Copy link
Contributor Author

mprse commented Jan 9, 2019

@mprse Please rebase again (sorry). The base branch has been rebased and updated.

Yes, I asked @0xc0170 to rebase spi feature branch because of the Travis issues.

@mprse mprse force-pushed the spi_feature_branch_test_com_icetea branch from 52ffce7 to 269d150 Compare January 10, 2019 06:46
@mprse
Copy link
Contributor Author

mprse commented Jan 10, 2019

Rebased after spi feature branch has been rebased on master to solve Travis issue.

@0xc0170 0xc0170 force-pushed the feature-hal-spec-spi branch from 9b1ccaa to c81f1e5 Compare January 14, 2019 09:33
@mprse mprse force-pushed the spi_feature_branch_test_com_icetea branch from 269d150 to e73b496 Compare January 14, 2019 11:01
@mprse mprse force-pushed the spi_feature_branch_test_com_icetea branch from e73b496 to 4984485 Compare January 14, 2019 11:44
@mprse
Copy link
Contributor Author

mprse commented Jan 14, 2019

Rebased and fixed style.

@0xc0170 0xc0170 merged commit 9030e5c into ARMmbed:feature-hal-spec-spi Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants