Update mbed_mem_tracing config option #8487

kegilbert · 2018-10-19T21:06:24Z

Description

This reverts most of commit 9b53d12

#8106 taught me that I can use a default value of null to have the config macro be not defined in mbed_config.h. Reverting my old changes that moved all of the mbed_mem_tracing option checks from #if !defined(....) to #if ... which caused minor breaking changes.

Move the memory tracing enabled macro to a config option but revert the !defined -> #if changes to no longer cause breaking changes as #7402 did.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

0xc0170 · 2018-10-23T08:25:50Z

platform/mbed_lib.json

        "error-filename-capture-enabled": {
            "help": "Enables capture of filename and line number as part of error context capture, this works only for debug and develop builds. On release builds, filename capture is always disabled",
            "value": false
        },
-        
+


This spacing fix should be a separate commit

0xc0170 · 2018-10-23T08:26:45Z

#8106 taught me that I can use a default value of null to have the config macro be not defined in mbed_config.h. Reverting my old changes that moved all of the mbed_mem_tracing option checks from #if !defined(....) to #if ... which caused minor breaking changes.

As you learned the lesson about #ifdef vs #if and config options, is this documented anywhere ?

kegilbert · 2018-10-23T13:11:08Z

@0xc0170 Good point, we do have some tickets for improving the config systems docs for 5.11 that we're working on.

cmonr · 2018-10-25T15:30:14Z

So if we're revering a breaking change, does that make this a breaking change?

kegilbert · 2018-10-25T18:10:41Z

@cmonr This is not a full revert of the last change. The breaking change from before was having a macro defined would cause a warning. If someone is using the old PR (say 5.10.2) and they updated to this they should see no issue as they'd have already moved to using the config system. If a user is still using the old macro define (<5.9) this will work as expected too.

kegilbert · 2018-10-26T14:01:01Z

Fixed the merge conflict.

@0xc0170 are the whitespace changes alright now?

0xc0170 · 2018-10-26T14:03:18Z

Removing breaking change, as this is not.

0xc0170 · 2018-10-26T14:04:30Z

@0xc0170 are the whitespace changes alright now?

I still see them as part of the commit that does other changes, can you create a new one?

kegilbert · 2018-10-26T17:48:25Z

Ahhh shoot rebase put the spaces back in...one second

Move the memory tracing enabled macro to a config option but revert the !defined -> #if changes to no longer cause breaking changes.

kegilbert · 2018-10-26T22:36:30Z

@0xc0170 Updated

0xc0170 · 2018-10-29T10:16:48Z

I requested also core team to review (meanwhile we run CI)

/morph build

mbed-ci · 2018-10-29T11:02:02Z

Build : FAILURE

Build number : 3490
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8487/

0xc0170 · 2018-10-29T11:14:21Z

The errors looks unrelated (one example does not fit, another failure is in the example python script)

/morph build

mbed-ci · 2018-10-29T12:37:59Z

Build : FAILURE

Build number : 3493
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8487/

cmonr · 2018-10-29T12:50:16Z

Found in the build_wrapper job:

10:18:36 abort: HTTP Error 502: Bad Gateway

/morph build

cmonr · 2018-10-29T12:51:03Z

@kegilbert This should probably be fixed:

doxygen doxyfile_options
/builds/ws/mbed-os-pipeline/features/netsocket/emac-drivers/TARGET_Silicon_Labs/sl_emac_config.h:4: warning: multiple use of section label 'License' while adding section, (first occurrence: /builds/ws/mbed-os-pipeline/features/netsocket/emac-drivers/TARGET_Silicon_Labs/sl_emac.h, line 4)
/builds/ws/mbed-os-pipeline/features/netsocket/emac-drivers/TARGET_Silicon_Labs/sl_eth_hw.h:4: warning: multiple use of section label 'License' while adding section, (first occurrence: /builds/ws/mbed-os-pipeline/features/netsocket/emac-drivers/TARGET_Silicon_Labs/sl_emac.h, line 4)
/builds/ws/mbed-os-pipeline/features/netsocket/emac-drivers/TARGET_Silicon_Labs/sl_eth_phy.h:4: warning: multiple use of section label 'License' while adding section, (first occurrence: /builds/ws/mbed-os-pipeline/features/netsocket/emac-drivers/TARGET_Silicon_Labs/sl_emac.h, line 4)
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copybrief or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copybrief or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copybrief or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copybrief or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copydetails or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copybrief or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copybrief or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copydetails or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copybrief or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copybrief or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copydetails or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copybrief or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copybrief or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copydetails or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copybrief or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copybrief or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/EthInterface.h:31: warning: @copydetails or @copydoc target 'NetworkInterface::ethInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copybrief or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copybrief or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/MeshInterface.h:30: warning: @copydetails or @copydoc target 'NetworkInterface::meshInterface' not found
/builds/ws/mbed-os-pipeline/features/netsocket/CellularBase.h:108: warning: @copybrief or @copydoc target 'NetworkInterface::cellularBase' not found
/builds/ws/mbed-os-pipeline/features/netsocket/CellularBase.h:108: warning: @copybrief or @copydoc target 'NetworkInterface::cellularBase' not found
/builds/ws/mbed-os-pipeline/features/netsocket/CellularBase.h:108: warning: @copydetails or @copydoc target 'NetworkInterface::cellularBase' not found

Also found in the build_wapper job

mbed-ci · 2018-10-29T14:00:01Z

Build : SUCCESS

Build number : 3495
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8487/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-29T16:54:19Z

Exporter Build : SUCCESS

Build number : 3112
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8487/

mbed-ci · 2018-10-29T18:05:18Z

Test : SUCCESS

Build number : 3279
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8487/3279

cmonr · 2018-10-29T23:52:53Z

For the occasional historian or lurker, it turns out that #8487 (comment) was allowed into master because the Travis CI version of doxygen is woefully out of date (Dec 2013 was when it was released).

kegilbert requested a review from cmonr October 19, 2018 21:06

cmonr added the needs: review label Oct 19, 2018

cmonr requested a review from c1728p9 October 19, 2018 22:33

0xc0170 requested changes Oct 23, 2018

View reviewed changes

c1728p9 approved these changes Oct 23, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Oct 24, 2018

kegilbert force-pushed the mbed_mem_trace_config_patch2 branch 4 times, most recently from d5d5358 to 0f661fb Compare October 24, 2018 14:44

cmonr added the release-version: 5.11.0-rc1 label Oct 25, 2018

cmonr added the BREAKING-CHANGE label Oct 25, 2018

kegilbert force-pushed the mbed_mem_trace_config_patch2 branch from 0f661fb to d8782c0 Compare October 26, 2018 14:00

0xc0170 removed the BREAKING-CHANGE label Oct 26, 2018

kegilbert force-pushed the mbed_mem_trace_config_patch2 branch 2 times, most recently from 33465f8 to 7ecb974 Compare October 26, 2018 22:28

This reverts commit 9b53d12.i

a2ac895

Move the memory tracing enabled macro to a config option but revert the !defined -> #if changes to no longer cause breaking changes.

kegilbert force-pushed the mbed_mem_trace_config_patch2 branch from 7ecb974 to a2ac895 Compare October 26, 2018 22:35

0xc0170 approved these changes Oct 29, 2018

View reviewed changes

0xc0170 added the needs: CI label Oct 29, 2018

0xc0170 removed the needs: work label Oct 29, 2018

0xc0170 requested a review from a team October 29, 2018 10:16

cmonr added ready for merge and removed needs: CI labels Oct 29, 2018

cmonr merged commit c9eaddd into ARMmbed:master Oct 29, 2018

cmonr removed the ready for merge label Oct 29, 2018

kegilbert mentioned this pull request Nov 14, 2018

Patch whitespace inconsistencies in platform lib file #8734

Merged

Update mbed_mem_tracing config option #8487

Update mbed_mem_tracing config option #8487

Uh oh!

Conversation

kegilbert commented Oct 19, 2018

Description

Pull request type

Uh oh!

0xc0170 Oct 23, 2018

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 23, 2018

Uh oh!

kegilbert commented Oct 23, 2018

Uh oh!

cmonr commented Oct 25, 2018

Uh oh!

kegilbert commented Oct 25, 2018

Uh oh!

kegilbert commented Oct 26, 2018

Uh oh!

0xc0170 commented Oct 26, 2018

Uh oh!

0xc0170 commented Oct 26, 2018

Uh oh!

kegilbert commented Oct 26, 2018

Uh oh!

kegilbert commented Oct 26, 2018

Uh oh!

0xc0170 commented Oct 29, 2018

Uh oh!

mbed-ci commented Oct 29, 2018

Build : FAILURE

Uh oh!

0xc0170 commented Oct 29, 2018

Uh oh!

mbed-ci commented Oct 29, 2018

Build : FAILURE

Uh oh!

cmonr commented Oct 29, 2018

Uh oh!

cmonr commented Oct 29, 2018

Uh oh!

mbed-ci commented Oct 29, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Oct 29, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Oct 29, 2018

Test : SUCCESS

Uh oh!

cmonr commented Oct 29, 2018

Uh oh!

Uh oh!