Update linker scripts for bootloader target L496GZ #8508

micgur01 · 2018-10-23T13:04:46Z

Description

Add MBED_APP_START and MBED_APP_SIZE to linker script so the start and size of an image can be specified. This allows the ROM to be split into a bootloader region and an application region.
Tested on NUCLEO_L496ZG, had to build bootloader as well with this fix.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

cmonr · 2018-10-23T15:43:33Z

@micgur01 Would you mind mentioning in the PR description what was updated instead of just mentioning that they were updated

jeromecoutant · 2018-10-23T15:54:22Z

targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/device/TOOLCHAIN_IAR/stm32l496xx.icf

@@ -1,7 +1,10 @@
+if (!isdefinedsymbol(MBED_APP_START)) { define symbol MBED_APP_START = 0x08000000; }
+if (!isdefinedsymbol(MBED_APP_SIZE)) { define symbol MBED_APP_SIZE = 0x80000; }


Not 0x100000 ?

That's the previous value, maybe it's a other issue - but not familiar enough with details
The change only not to be hardcoded

That's the previous value

No... it was 0x100000
define symbol region_ROM_end = 0x08000000 + 0x100000 - 1;

you are right, checking
maybe i took it from other target ( 429)

jeromecoutant · 2018-10-23T15:56:52Z

targets/targets.json

@@ -4282,7 +4282,8 @@
        "detect_code": ["0823"],
        "device_has_add": ["ANALOGOUT", "CAN", "CRC", "SERIAL_ASYNCH", "SERIAL_FC", "TRNG", "FLASH"],
        "release_versions": ["2", "5"],
-        "device_name": "STM32L496ZG"
+        "device_name": "STM32L496ZG",
+        "bootloader_supported": true


Could you add bootloader_supported to DISCO_L496AG also ?

jeromecoutant

It seems also that you need to add
#! armcc -E
in ARM sct files

Thx

micgur01 · 2018-10-24T09:51:20Z

Hi
is it related to current fix? Could you explain what does it means?
I can see it not in every ARM sct files.

#! armcc -E
in ARM sct files

jeromecoutant · 2018-10-24T09:55:22Z

I don't know...
But without that line, your patch can't compile.

micgur01 · 2018-10-24T11:20:33Z

Hi
Delivered latest code review fixes
Thank you very much for your comments

0xc0170 · 2018-10-24T11:47:32Z

#! armcc -E

To run preprocessor on the linker scripts. In this case, because we got some config we want to pass to the linker script, we need this step.

0xc0170 · 2018-10-24T11:55:57Z

@micgur01 How was this tested (as ARMCC failure was not found earlier)?

micgur01 · 2018-10-24T12:09:56Z

It's my fault , first time delivering to mbed-os
I did not checked for all toolchains, run tests only for ARM_GCC

jeromecoutant

ST CI quick test OK :

target	platform_name	test suite	result	elapsed_time (sec)	copy_method
DISCO_L496AG-ARM	DISCO_L496AG	tests-mbed_drivers-echo	OK	18.11	default
DISCO_L496AG-GCC_ARM	DISCO_L496AG	tests-mbed_drivers-echo	OK	19.08	default
DISCO_L496AG-IAR	DISCO_L496AG	tests-mbed_drivers-echo	OK	19.05	default
NUCLEO_L496ZG-ARM	NUCLEO_L496ZG	tests-mbed_drivers-echo	OK	18.75	default
NUCLEO_L496ZG-GCC_ARM	NUCLEO_L496ZG	tests-mbed_drivers-echo	OK	19.31	default
NUCLEO_L496ZG-IAR	NUCLEO_L496ZG	tests-mbed_drivers-echo	OK	18.58	default

0xc0170 · 2018-10-24T13:41:15Z

@jeromecoutant Thanks for the test results 👍

/morph build

mbed-ci · 2018-10-24T14:28:40Z

Build : SUCCESS

Build number : 3451
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8508/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-24T15:41:43Z

Exporter Build : SUCCESS

Build number : 3073
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8508/

mbed-ci · 2018-10-24T16:02:23Z

Test : SUCCESS

Build number : 3243
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8508/3243

adbridge · 2018-11-02T12:26:56Z

Mmm something funny in this PR:
error: patch failed: targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/device/TOOLCHAIN_IAR/stm32l496xx.icf:1
error: targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/device/TOOLCHAIN_IAR/stm32l496xx.icf: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.

I'll try hand patching it at the end

cmonr · 2018-11-05T04:32:02Z

For future reference, figured out the patching issue.

We need to be passing the --keep-cr flag when running git am -3

micgur01 added 2 commits October 23, 2018 12:57

Update linker scripts for bootloader for L496GZ

ff4b567

change mode to 664

5348830

jeromecoutant reviewed Oct 23, 2018

View reviewed changes

cmonr added the needs: work label Oct 23, 2018

jeromecoutant reviewed Oct 23, 2018

View reviewed changes

jeromecoutant suggested changes Oct 24, 2018

View reviewed changes

code review for Update linker scripts for bootloader target L496GZ

2215a9a

code review for Update linker scripts for bootloader target L496GZ

6c191c0

0xc0170 approved these changes Oct 24, 2018

View reviewed changes

jeromecoutant approved these changes Oct 24, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Oct 24, 2018

cmonr added ready for merge release-version: 5.10.3 and removed needs: CI labels Oct 24, 2018

cmonr merged commit 140f3e2 into ARMmbed:master Oct 25, 2018

cmonr removed the ready for merge label Oct 25, 2018

adbridge added the Manually Patch label Nov 2, 2018

adbridge removed the release-version: 5.10.3 label Nov 2, 2018

cmonr added release-version: 5.10.3 and removed Manually Patch labels Nov 5, 2018

adbridge added Manually Patch release-version: 5.10.3 and removed release-version: 5.10.3 Manually Patch labels Nov 5, 2018

		@@ -1,7 +1,10 @@
		if (!isdefinedsymbol(MBED_APP_START)) { define symbol MBED_APP_START = 0x08000000; }
		if (!isdefinedsymbol(MBED_APP_SIZE)) { define symbol MBED_APP_SIZE = 0x80000; }

Update linker scripts for bootloader target L496GZ #8508

Update linker scripts for bootloader target L496GZ #8508

Uh oh!

Conversation

micgur01 commented Oct 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

cmonr commented Oct 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

micgur01 commented Oct 24, 2018

Uh oh!

jeromecoutant commented Oct 24, 2018

Uh oh!

micgur01 commented Oct 24, 2018

Uh oh!

0xc0170 commented Oct 24, 2018

Uh oh!

0xc0170 commented Oct 24, 2018

Uh oh!

micgur01 commented Oct 24, 2018

Uh oh!

jeromecoutant left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 24, 2018

Uh oh!

mbed-ci commented Oct 24, 2018

Triggering tests

Uh oh!

mbed-ci commented Oct 24, 2018

Uh oh!

mbed-ci commented Oct 24, 2018

Uh oh!

adbridge commented Nov 2, 2018

Uh oh!

cmonr commented Nov 5, 2018

Uh oh!

Uh oh!

micgur01 commented Oct 23, 2018 •

edited

Loading