Merge duplicate keys in JSON. #8515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description
I would love to make this an error, but we have had a duplicate key in
`targets.json` for a while now. Instead, we're merging in a semi-smart way.
This will allow you to have things like `"target.features_add"` twice, and
both will take affect.
### Pull request type
[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
cmonr
approved these changes
Oct 23, 2018
|
/morph build |
Build : SUCCESSBuild number : 3444 Triggering tests/morph test |
Test : FAILUREBuild number : 3232 |
Exporter Build : SUCCESSBuild number : 3065 |
|
Job config fixed. |
Test : SUCCESSBuild number : 3235 |
logging warning at least so we start cleaning them up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I would love to make this an error, but we have had a duplicate key in
targets.jsonfor a while now. Instead, we're merging in a semi-smart way.This will allow you to have things like
"target.features_add"twice, andboth will take affect.
Pull request type