Skip to content

Rollup PR - UK Docathon pt1 #8519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 24, 2018
Merged

Rollup PR - UK Docathon pt1 #8519

merged 20 commits into from
Oct 24, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Oct 24, 2018

Description

Rollup PR for the following PRs:

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

mprse and others added 20 commits October 23, 2018 12:18
@mprse
mbed_rtc_time.h - documentation fix
0a1e3a0 
Make example code consistent with:
https://os.mbed.com/teams/mbed_example/code/time_HelloWorld/file/0c6401d671c6/main.cpp/
@pan-
Span: Improve documentation
a0786ad 
Makes doxygen reference to SPAN_DYNAMIC_EXTENT by name instead of the macro expansion -1.
Add reference to the macro in the class documentation.
@pan-
Span: Add related non member function to class documentation.
03d308d
@pan-
Span: Improve subspan return type.
c956a93 
This clarifies code and documentation generated.
@paul-szczepanek-arm
fix documentation and example
52a0b64
@pan-
Span: define doc groups.
1e30ed5
EventFlags docs update.
e2b117f
@paul-szczepanek-arm
doxygen cleanup
68929ce
@paul-szczepanek-arm
hide protected
f9ae6a3
@ConradBraam
Explain default port number, and construction
e919511
Copy edit I2CSlave.h
7fa3a44 
Make minor copy edits.
Edit SPISlave.h
7637c61 
Make minor edits to existing text.
Add comma to SocketAddress.h
0a82253 
Add comma to existing text.
Edit EventFlags.h
57b7940 
Make minor copy edits to existing text.
Merge branch 'docs_update-eventflags' of ssh://github.com/fkjagodzins…
2393b0b 
…ki/mbed-os into rollup
Merge branch 'conbra01/docaton_networksocket' of ssh://github.com/Con…
975be7b 
…radBraam/mbed-os into rollup
Merge branch 'doc-fix-spi_slave' of ssh://github.com/paul-szczepanek-…
2274fc8 
…arm/mbed-os into rollup
Merge branch 'doc-fix-i2c_slave' of ssh://github.com/paul-szczepanek-…
0e2983e 
…arm/mbed-os into rollup
Merge branch 'span-doc' of ssh://github.com/pan-/mbed into rollup
408051a
Merge branch 'mbed_rtc_time_example_fix' of ssh://github.com/mprse/mb…
fe1d6b0 
…ed-os into rollup
@cmonr cmonr requested a review from a team October 24, 2018 03:42
@cmonr
Copy link
Contributor Author

cmonr commented Oct 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2018

Build : SUCCESS

Build number : 3449
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8519/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2018

Exporter Build : SUCCESS

Build number : 3070
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8519/

@mbed-ci
Copy link

mbed-ci commented Oct 24, 2018

Test : SUCCESS

Build number : 3240
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8519/3240

NirSonnenschein
NirSonnenschein approved these changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks ok, but I find the addition of this comment a bit strange:
/** \addtogroup platform /
/* @{*/
/**

  • \defgroup platform_Span Span class
  • @{
    */

@cmonr cmonr merged commit b18c819 into ARMmbed:master Oct 24, 2018
@cmonr cmonr removed the needs: CI label Oct 24, 2018
@cmonr cmonr deleted the rollup branch October 26, 2018 02:49
@cmonr cmonr mentioned this pull request Nov 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cmonr @mbed-ci @0xc0170 @NirSonnenschein @mprse @pan- @paul-szczepanek-arm @ConradBraam