Skip to content

MbedCRC docs update #8521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Conversation

maciejbocianski
Copy link
Contributor

Description

Minor docs update for the MbedCRC class

@deepikabhavnani can you confirm that single doxygen for both constructors and no doxygen for destructor was intentional?

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[X] Docs update
[ ] Test update
[ ] Breaking change

@@ -258,6 +258,7 @@ class MbedCRC {
* This API is used to perform final computation to get correct CRC value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Mbed is styled incorrectly in license info at top of page. It's not within the set of changes for this commit, so I can't attach this to the correct line.

Copy link
Contributor Author

@maciejbocianski maciejbocianski Oct 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the line:

/* mbed Microcontroller Library

But all mbed source use this license header style

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melwee01 What shall be fixed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mbed - Mbed
It should be fixed in all the files

/* mbed Microcontroller Library

/* mbed Microcontroller Library

@0xc0170 - We don't have consistent one license header across all files in repo :-(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I keep getting errors when building doxy files because of license headers in a couple files. They're not files that are part of any PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But yes. mbed -> Mbed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 - We don't have consistent one license header across all files in repo :-(

Definitely. I'll add it to the docs to start the unification

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepikabhavnani
Copy link

can you confirm that single doxygen for both constructors and no doxygen for destructor was intentional?

I guess that was for consistency, all the drivers have single doxygen for constructor/destructor, and mainly for empty destructors.

@AnotherButler
Copy link
Contributor

Note: @oliverjharper is talking with legal about changing old license text.

@cmonr
Copy link
Contributor

cmonr commented Oct 26, 2018

Note: This PR is now a part of a rollup PR (#8552).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

@cmonr cmonr merged commit 394df12 into ARMmbed:master Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants