-
Notifications
You must be signed in to change notification settings - Fork 3k
MbedCRC docs update #8521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MbedCRC docs update #8521
Conversation
@@ -258,6 +258,7 @@ class MbedCRC { | |||
* This API is used to perform final computation to get correct CRC value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Mbed is styled incorrectly in license info at top of page. It's not within the set of changes for this commit, so I can't attach this to the correct line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean the line:
Line 1 in 5b25b66
/* mbed Microcontroller Library |
But all mbed source use this license header style
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melwee01 What shall be fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. I keep getting errors when building doxy files because of license headers in a couple files. They're not files that are part of any PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yes. mbed -> Mbed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xc0170 - We don't have consistent one license header across all files in repo :-(
Definitely. I'll add it to the docs to start the unification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already there, just need to do a clean-up one day !
I guess that was for consistency, all the drivers have single doxygen for constructor/destructor, and mainly for empty destructors. |
Note: @oliverjharper is talking with legal about changing old license text. |
Note: This PR is now a part of a rollup PR (#8552). No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged. |
Description
Minor docs update for the
MbedCRC
class@deepikabhavnani can you confirm that single doxygen for both constructors and no doxygen for destructor was intentional?
Pull request type