Skip to content

Wifi: ublox fix to keep the credentials stored #8566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

AmmadRehmatCUS
Copy link

@AmmadRehmatCUS AmmadRehmatCUS commented Oct 29, 2018

Description

Following issue is fixed here:

UBLOX_EVK_ODIN_W2 does not pass Greentea testcase WIFI-CONNECT.

#8520

Toolchains tested:
GCC_ARM, ARM, IAR

Tests:
network-wifi

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 29, 2018

Description

Please always provide details even if it's simple fix (how is this being fixed, what platforms, how it was tested), add there some info.

@AmmadRehmatCUS
Copy link
Author

Description

Please always provide details even if it's simple fix (how is this being fixed, what platforms, how it was tested), add there some info.

Description added

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 29, 2018

One more I forgot to add - the commit can be expanded to provide information about the fix itself , similar to what the bug report is (so I do not need to go through the PR and bug report to obtain info what its being fixed)

This one looks like a good candidate: "fixes the credentials storage, copies them internally rather than just a pointer to external storage", based on:

Third connection attempt on the test case will fail due to the reason that driver tries to read SSID from a memory location not managed by it and the data has been trashed. Assumption is that driver would keep the credentials (SSID, password) stored between different connection attempts.

@AmmadRehmatCUS
Copy link
Author

One more I forgot to add - the commit can be expanded to provide information about the fix itself , similar to what the bug report is (so I do not need to go through the PR and bug report to obtain info what its being fixed)

This one looks like a good candidate: "fixes the credentials storage, copies them internally rather than just a pointer to external storage", based on:

Third connection attempt on the test case will fail due to the reason that driver tries to read SSID from a memory location not managed by it and the data has been trashed. Assumption is that driver would keep the credentials (SSID, password) stored between different connection attempts.

Commit message update

@0xc0170 0xc0170 changed the title Fix for issue 8520- failing wifi test case Wifi: ublox fix to keep the credentials stored Oct 29, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 29, 2018

Thanks @AmmadRehmat for the updates. I also update the title

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

Build : SUCCESS

Build number : 3497
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8566/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 30, 2018

@cmonr cmonr merged commit 1bbcfff into ARMmbed:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants