Skip to content

Release candidate #8637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 198 commits into from
Closed

Release candidate #8637

wants to merge 198 commits into from

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Nov 5, 2018

No description provided.

SenRamakri and others added 30 commits November 2, 2018 19:49
While investigating the RX issue on NRF52_DK after SDK 14 updates,
it is observed that the RX FIFO doesn't get filled up, when the
flow control is disabled. Hence the readable never returns true.
If using Serial interface, the stdio file handles (0, 1, 2) get opened.
This results in configuring the flow control for STDIO, and it is observed
that the RX FIFO gets filled.

However, if RawSerial is used, the STDIO file handles
don't get opened. During the debug process it was observed that if the
flow control is configured once and then set to disabled, RX worked
as expected.

Alternative to this approach is that user application specifically
enables flow control as done in mbed's Greentea test suite. See https://goo.gl/r8nBYH

See https://goo.gl/8VB2qg step 14 for _initio's description.
See test code to reproduce the issue and test fix here: https://goo.gl/AQU1xG

Description
The change in behavior with NRF52's UART RX is documented here. #6891
This change is a fix for the above issue.
While investigating the RX issue on NRF52_DK after SDK 14 updates,
it is observed that the RX FIFO doesn't get filled up, when the
flow control is disabled. Hence the readable never returns true.
If using Serial interface, the stdio file handles (0, 1, 2) get opened.
This results in configuring the flow control for STDIO, and it is observed
that the RX FIFO gets filled.

However, if RawSerial is used, the STDIO file handles
don't get opened. During the debug process it was observed that if the
flow control is configured once and then set to disabled, RX worked
as expected.

Alternative to this approach is that user application specifically
enables flow control as done in mbed's Greentea test suite. See https://goo.gl/r8nBYH

See https://goo.gl/8VB2qg step 14 for _initio's description.
See test code to reproduce the issue and test fix here: https://goo.gl/AQU1xG

Description
The change in behavior with NRF52's UART RX is documented here. #6891
This change is a fix for the above issue.
…ppearing on docs site. - Standardize units of time (microsecond, millisecond). - Improve example description.
Add "s" for agreement.
Edit for active voice.
### Description

Exporting to GNU ARM Eclipse, E2 Studio, and other exclude-based IDEs
currently generats unusable project files online. This is because the
list of directories ignored in the scan is inconsistant about what sort
of paths are used: logical paths, or phisical paths. This patch makes
all paths in ignored_dirs logical. This should fix the excluding tags
in these project files.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change
### Description

The `mbed compile -S` command is suposed to indicate what targets
support what toolchains. The command was printing out things that
don't make sense, like `GCC_CR` and things that make sense, but are
not offiially supported yet, like `ARMC6`. This PR fixes all of that.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change
### Description

The `mbed compile` would traceback when no linker script is found.
This PR changes that behavior to make that into a NotSupportedException,
which has decent user behavior.

Fixes #7723

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change
This is fix for issue 8368.

Test is causing some problems on `REALTEK_RTL8195AM` and `ARM` compiler. There is some kind of memory issue. Probably there is not enough memory space for global data provided by the test. Data definitions have been moved into test function body so, they will land on stack. With this fix the test works on `REALTEK_RTL8195AM/ARM`.
@cmonr cmonr force-pushed the release-candidate branch 2 times, most recently from 351121b to 4a14db5 Compare November 5, 2018 04:30
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2018

The error comes from SocketAddress.cpp:83:30: error: could not convert ‘stoip6(addr, strlen(addr), ((void*)((uint8_t*)(&((SocketAddress*)this)->SocketAddress::_addr.nsapi_addr::bytes))))’ from ‘void’ to ‘bool’. I suspect latest commit breaks it.

One more, I could not locate update mbed_version.h file?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2018

stoip6 - return type declared as void on 5.10.x. But on master it was already fixed (return type bool). See #8245

#8003 - goes to 5.11. We need to rebuild the release candidate (also check the version update)

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 5, 2018

I'll close, we will reopen with an update or new PR

@0xc0170 0xc0170 closed this Nov 5, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 5, 2018
@cmonr
Copy link
Contributor Author

cmonr commented Nov 5, 2018

One more, I could not locate update mbed_version.h file?

Huh. Thought I ended up applying that last patch. Oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.