-
Notifications
You must be signed in to change notification settings - Fork 3k
Detect xinetd service pattern and generate correct pattern (ONME-3733) #8645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SeppoTakalo please review. |
Looks good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review astyle travis job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK with local ST server with XINETD service
and still OK with ARM server (echo.mbedcloudtesting.com)
Note that ONME-3733 seems to be #7292 |
00b8fef
to
11b650c
Compare
astyle fixed. @0xc0170 please review. |
I can still see couple of things the Astyle changed: One is just whitespace at the end of line. Others are visible. |
11b650c
to
655ab0f
Compare
FIxed. |
655ab0f
to
5eabfab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
/morph build |
Build : SUCCESSBuild number : 3575 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3186 |
Test : SUCCESSBuild number : 3354 |
Description
Task ONE-3733. Add support for xinetd chargen service. Modify pattern creation function to be compatible with xinetd chargen service.
Pull request type